Skip to content

Update Ruby SDK #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2020
Merged

Update Ruby SDK #10

merged 1 commit into from
Sep 18, 2020

Conversation

biglovisa
Copy link
Contributor

@biglovisa biglovisa commented Sep 17, 2020 •
edited
Loading

  • photos field to projects
  • average_price_per_tonne field to projects
  • remaining_mass_g field to projects
  • standard field to projects
  • validations on mass_g field (has to be greater than 1 and less than 2,000,000,000).

@biglovisa biglovisa requested a review from thdaraujo September 17, 2020 23:00
thdaraujo
thdaraujo previously requested changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@thdaraujo thdaraujo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating the gem!

do you mind adding integration tests to these new fields?
please also update the readme examples.

@biglovisa biglovisa requested a review from thdaraujo September 18, 2020 19:03
@biglovisa
Copy link
Contributor Author

@thdaraujo good point! Just pushed a commit with integration tests.

bspellacy
bspellacy reviewed Sep 18, 2020
View reviewed changes
bspellacy
bspellacy reviewed Sep 18, 2020
View reviewed changes
@biglovisa biglovisa requested a review from bspellacy September 18, 2020 19:14
bspellacy
bspellacy approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@bspellacy bspellacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@biglovisa biglovisa dismissed thdaraujo’s stale review September 18, 2020 19:26

Talked offline about requested changes; approved by Brennan

@biglovisa biglovisa merged commit 6a33347 into main Sep 18, 2020
@biglovisa biglovisa deleted the lovisa/bump-version branch September 18, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bspellacy bspellacy bspellacy approved these changes

@thdaraujo thdaraujo Awaiting requested review from thdaraujo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@biglovisa @thdaraujo @bspellacy