Skip to content

[v1.3.0] Add Flight/Shipping/Vehicle estimates #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 9, 2021
Merged

[v1.3.0] Add Flight/Shipping/Vehicle estimates #20

merged 3 commits into from
Feb 9, 2021

Conversation

biglovisa
Copy link
Contributor

@biglovisa biglovisa commented Feb 8, 2021 •
edited
Loading

What

  • Adding support for creating Shipping, Vehicle, and Flight estimates
  • Upgrading to v.1.2.6

Why

  • To extend the Ruby gem to support different kinds of estimates to be created

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the gem locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production? N/A

@biglovisa biglovisa self-assigned this Feb 8, 2021
@biglovisa biglovisa added the Needs Review The PR is ready to be reviewed label Feb 8, 2021
@biglovisa biglovisa requested a review from thdaraujo February 8, 2021 19:26
@biglovisa biglovisa force-pushed the lovisa/version-1.2.6 branch from 2a7b9c9 to 800f311 Compare February 8, 2021 20:13
@biglovisa biglovisa force-pushed the lovisa/version-1.2.6 branch from 800f311 to 05f78a4 Compare February 8, 2021 20:19
@bspellacy
Copy link
Member

This should be a minor bump and not a patch.

@biglovisa biglovisa changed the title [v1.2.6] Add Flight/Shipping/Vehicle estimates [v1.3.5] Add Flight/Shipping/Vehicle estimates Feb 8, 2021
@biglovisa biglovisa changed the title [v1.3.5] Add Flight/Shipping/Vehicle estimates [v1.3.0] Add Flight/Shipping/Vehicle estimates Feb 8, 2021
thdaraujo
thdaraujo approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding tests 🙌

spec/integration/estimates_spec.rb
@@ -24,4 +24,47 @@

expect(estimates.length).not_to be_zero
end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@thdaraujo thdaraujo added Ready This PR is ready to ship! and removed Needs Review The PR is ready to be reviewed labels Feb 8, 2021
@biglovisa biglovisa merged commit 88e34d0 into main Feb 9, 2021
@biglovisa biglovisa deleted the lovisa/version-1.2.6 branch February 9, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thdaraujo thdaraujo thdaraujo approved these changes

Assignees

@biglovisa biglovisa

Labels
Ready This PR is ready to ship!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@biglovisa @bspellacy @thdaraujo