Skip to content

Add issued_to field to Orders APIs #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2022
Merged

Conversation

holtbp
Copy link
Contributor

@holtbp holtbp commented Jun 4, 2022

What

Added support for issued_to field to Order create and place APIs (and returned in Order response).

Why

This allows our partners to create orders and place orders on behalf of other parties.

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the gem locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version in the code generator?
  • If endpoints were removed, did you manually remove the corresponding files? (this should be rare)
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@holtbp
Copy link
Contributor Author

holtbp commented Jun 4, 2022

Need to build the gem locally and test on Monday

@holtbp holtbp requested a review from a team June 4, 2022 00:30
@holtbp holtbp merged commit f340aee into main Jun 6, 2022
@holtbp holtbp deleted the bh-add-orders-support-issued_to branch June 6, 2022 18:52
data, _status_code, _headers = place_order_with_http_info(id, opts)
def place_order(id, place_order_request = {}, opts = {})
_place_order_request = Patch::PlaceOrderRequest.new(place_order_request)
data, _status_code, _headers = place_order_with_http_info(id, opts.merge!({place_order_request: place_order_request}))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@holtbp to confirm, because I think it is the crux of the weird shit I'm trying to debug: did you by any chance add this .merge! manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants