Add Patch::Estimate methods for GLEC-certified shipping estimates #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holtbp
force-pushed
the
bh-shipping-estimates
branch
from
96aa406 to
6e4fecd
Compare
holtbp
requested review from
a team and
boconnell2
and removed request for
a team and
boconnell2
holtbp
commented
Jul 22, 2022
| @@ -232,7 +232,7 @@ def valid? | |||
| return false if !@mass_g.nil? && @mass_g > 100000000000 | |||
| return false if !@mass_g.nil? && @mass_g < 0 | |||
| return false if !@total_price_cents_usd.nil? && @total_price_cents_usd < 1 | |||
| state_validator = EnumAttributeValidator.new('String', ["draft", "placed"]) | |||
| state_validator = EnumAttributeValidator.new('String', ["draft", "reserved", "placed"]) | |||
There was a problem hiding this comment.
@joustrich Is introducing this okay?
There was a problem hiding this comment.
On behalf of @joustrich, I'll say yes 😁
There was a problem hiding this comment.
Shoot sorry I totally missed this. Yes we do want this in there!
kleinjm
approved these changes
Jul 25, 2022
|
@holtbp don't forget a PR for your changes to https://github.com/patch-technology/client-code-generation too! |
pcothenet
approved these changes
Jul 25, 2022
pcothenet
reviewed
Jul 29, 2022
Comment on lines
-169
to
+171
| def place_order(id, place_order_request = {}, opts = {}) | ||
| _place_order_request = Patch::PlaceOrderRequest.new(place_order_request) | ||
| data, _status_code, _headers = place_order_with_http_info(id, opts.merge!({place_order_request: place_order_request})) | ||
| def place_order(order_id, opts = {}) | ||
| place_order_request = Patch::PlaceOrderRequest.new(opts) | ||
| opts[:place_order_request] = place_order_request | ||
| data, _status_code, _headers = place_order_with_http_info(order_id, opts) |
There was a problem hiding this comment.
@holtbp finding out after the fact, but it looks like it's a change you generated manually, is it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Patch::Estimate.create_air_shipping_estimatemethodPatch::Estimate.create_rail_shipping_estimatemethodPatch::Estimate.create_road_shipping_estimatemethodPatch::Estimate.create_sea_shipping_estimatemethodWhy
To provide GLEC-certified shipping estimates!
SDK Release Checklist