Skip to content

add project_id to estimates and orders #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 20, 2020
Merged

add project_id to estimates and orders #7

merged 7 commits into from
Aug 20, 2020

Conversation

thdaraujo
Copy link
Contributor

What

  • adds project_id field to estimates and order creation
  • adds metadata field to order creation
  • adds changelog and updates to the readme
  • updates the gem version

@thdaraujo thdaraujo self-assigned this Aug 19, 2020
@thdaraujo thdaraujo requested a review from bspellacy August 19, 2020 20:02
@bspellacy
Copy link
Member

Looking good @thdaraujo - could you please add some e2e tests for the newly added functionality?

@thdaraujo thdaraujo force-pushed the ta/regenerate-ruby-client branch 2 times, most recently from 6ad1a87 to 3ab8c37 Compare August 19, 2020 22:21
@thdaraujo thdaraujo force-pushed the ta/regenerate-ruby-client branch from 3ab8c37 to 68ce248 Compare August 19, 2020 22:29
@thdaraujo
Copy link
Contributor Author

added some specs!

@thdaraujo thdaraujo merged commit 6f7671b into master Aug 20, 2020
@thdaraujo thdaraujo deleted the ta/regenerate-ruby-client branch October 13, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bspellacy bspellacy bspellacy approved these changes

Assignees

@thdaraujo thdaraujo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thdaraujo @bspellacy