Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add backward-compatibility-check workflow #154

Merged
merged 8 commits into from
Jan 7, 2022
Merged

add backward-compatibility-check workflow #154

merged 8 commits into from
Jan 7, 2022

Conversation

DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Dec 28, 2021 •
edited
Loading

fix #105

@DavidBadura DavidBadura added this to the 1.2.0 milestone Dec 28, 2021
@DavidBadura DavidBadura marked this pull request as draft December 28, 2021 14:56
@DavidBadura DavidBadura removed this from the 1.2.0 milestone Jan 2, 2022
@DanielBadura DanielBadura force-pushed the backward-compatibility-check branch from 64012c2 to 75bdca2 Compare January 4, 2022 22:12
@DanielBadura DanielBadura marked this pull request as ready for review January 4, 2022 22:13
@DanielBadura
Copy link
Member

I think the should push out the tools like this into a separate composer.json since alot of deps are getting pulled in which the user does not need. The SA tools (psalm, phpstan, phpcs) could stay in the normal json i think. WDYT @DavidBadura ?

@DavidBadura
Copy link
Member Author

Yes, let's do it that way, we can simply adjust it again if it doesn't fit :)

@DanielBadura DanielBadura force-pushed the backward-compatibility-check branch from ffca0bc to 5fe4907 Compare January 7, 2022 17:12
DanielBadura
DanielBadura reviewed Jan 7, 2022
View reviewed changes
.github/workflows/backward-compatibility-check.yml
working-directory: 'tools'

- name: "Check for BC breaks"
run: "tools/vendor/bin/roave-backward-compatibility-check --format=github-actions --install-development-dependencies"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not quite sure if we need the dev deps here..

@DavidBadura
Copy link
Member Author

LGTM

@DanielBadura DanielBadura merged commit dfc4ab2 into 1.2.x Jan 7, 2022
@DanielBadura DanielBadura deleted the backward-compatibility-check branch January 7, 2022 17:19
@DanielBadura DanielBadura added this to the 1.2.0 milestone Jan 7, 2022
@DanielBadura DanielBadura added the enhancement New feature or request label Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielBadura DanielBadura DanielBadura left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Introduce Roave/BackwardCompatibilityCheck as CI job
2 participants
@DavidBadura @DanielBadura