Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all unit-test with @covers annotation, add custom recordedOn test for AggregateChanged, use assertSame where possible, update infection config & badge #162

Merged
merged 6 commits into from
Jan 10, 2022

Conversation

DanielBadura
Copy link
Member

@DanielBadura DanielBadura commented Jan 8, 2022

fix #160

@DanielBadura DanielBadura added the enhancement New feature or request label Jan 8, 2022
@DanielBadura DanielBadura changed the title Update all unit-test with @covers annotation, add custom recordedOn test for AggregateChanged, update infection config & badge Update all unit-test with @covers annotation, add custom recordedOn test for AggregateChanged, use assertSame where possible, update infection config & badge Jan 8, 2022
@DanielBadura
Copy link
Member Author

Not sure what psalm wants here:

ERROR: DocblockTypeContradiction - tests/Unit/Aggregate/AggregateRootTest.php:63:15 - Docblock-defined type 1 for $profile->playhead() is never int(2) (see https://psalm.dev/155)
        self::assertSame(2, $profile->playhead());

@DavidBadura
Copy link
Member

Not sure what psalm wants here:

ERROR: DocblockTypeContradiction - tests/Unit/Aggregate/AggregateRootTest.php:63:15 - Docblock-defined type 1 for $profile->playhead() is never int(2) (see https://psalm.dev/155)
        self::assertSame(2, $profile->playhead());

I don't know, maybe we should add this in the psalm baseline

@DanielBadura
Copy link
Member Author

Maybe because playhead is readonly and already resutled in 1? I want to check it one more time before adding it to the baseline

@DavidBadura
Copy link
Member

on the aggregate, playhead is internal not readonly. on the aggregateChange it is readonly, but this is not used here.

@DavidBadura DavidBadura merged commit 3bc989d into 1.3.x Jan 10, 2022
@DavidBadura DavidBadura deleted the update-covers branch January 10, 2022 21:32
@DanielBadura DanielBadura added this to the 1.3.0 milestone Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use assertSame for scalar values in our tests
2 participants