Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve snapshot store related apis #215

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Conversation

DavidBadura
Copy link
Member

  • throw exception if an adapter is not found
  • make adpater method public
  • cleanup aggregate root metadata api
  • cleanup phpunit output

@DavidBadura DavidBadura added this to the 2.0.0 milestone Apr 21, 2022
@github-actions
Copy link

Hello 👋

here is the most recent benchmark result:

LoadEventsBench
===============

Average iteration times by variant

81.3ms    │ ██ 
71.2ms    │ ██ 
61.0ms    │ ██ 
50.8ms    │ ██ 
40.7ms    │ ██ 
30.5ms    │ ██ 
20.3ms    │ ██ 
10.2ms    │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

Memory by variant

19.1mb    │ ██ 
16.7mb    │ ██ 
14.3mb    │ ██ 
11.9mb    │ ██ 
9.5mb     │ ██ 
7.1mb     │ ██ 
4.8mb     │ ██ 
2.4mb     │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

+--------------------+-------------------+-------------------+-----------------+------------+
|                    | time (kde mode)                       | memory                       |
+--------------------+-------------------+-------------------+-----------------+------------+
| subject            | Tag: <current>    | Tag: base         | Tag: <current>  | Tag: base  |
+--------------------+-------------------+-------------------+-----------------+------------+
| benchLoadEvents () | 81.006ms (±0.04%) | 81.335ms (±0.44%) | 19.066mb        | 19.066mb   |
+--------------------+-------------------+-------------------+-----------------+------------+

LoadEventsWithSnapshotsBench
============================

Average iteration times by variant

264.3μs   │ ▇█ 
231.3μs   │ ██ 
198.2μs   │ ██ 
165.2μs   │ ██ 
132.2μs   │ ██ 
99.1μs    │ ██ 
66.1μs    │ ██ 
33.0μs    │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

Memory by variant

13.1mb    │ ██ 
11.4mb    │ ██ 
9.8mb     │ ██ 
8.2mb     │ ██ 
6.5mb     │ ██ 
4.9mb     │ ██ 
3.3mb     │ ██ 
1.6mb     │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

+--------------------+--------------------+--------------------+-----------------+------------+
|                    | time (kde mode)                         | memory                       |
+--------------------+--------------------+--------------------+-----------------+------------+
| subject            | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+--------------------+--------------------+--------------------+-----------------+------------+
| benchLoadEvents () | 259.352μs (±0.40%) | 264.305μs (±0.87%) | 13.069mb        | 13.068mb   |
+--------------------+--------------------+--------------------+-----------------+------------+

WriteEventsBench
================

Average iteration times by variant

36.2ms    │    █▇ 
31.7ms    │    ██ 
27.2ms    │    ██ 
22.6ms    │    ██ 
18.1ms    │    ██ 
13.6ms    │    ██ 
9.1ms     │    ██ 
4.5ms     │ ▂▂ ██ 
          └───────
            1  2  

[█ <current>] [█ base] 

1: benchSaveOneEvent    2: benchSaveAfterThous᠁ 

Memory by variant

7.0mb     │ ▃▃ ██ 
6.1mb     │ ██ ██ 
5.2mb     │ ██ ██ 
4.4mb     │ ██ ██ 
3.5mb     │ ██ ██ 
2.6mb     │ ██ ██ 
1.7mb     │ ██ ██ 
871.4kb   │ ██ ██ 
          └───────
            1  2  

[█ <current>] [█ base] 

1: benchSaveOneEvent    2: benchSaveAfterThous᠁ 

+---------------------------------+-------------------+-------------------+-----------------+------------+
|                                 | time (kde mode)                       | memory                       |
+---------------------------------+-------------------+-------------------+-----------------+------------+
| subject                         | Tag: <current>    | Tag: base         | Tag: <current>  | Tag: base  |
+---------------------------------+-------------------+-------------------+-----------------+------------+
| benchSaveOneEvent ()            | 1.067ms (±10.23%) | 1.096ms (±21.36%) | 6.336mb         | 6.336mb    |
| benchSaveAfterThousandEvents () | 36.210ms (±1.65%) | 35.635ms (±0.35%) | 6.971mb         | 6.971mb    |
+---------------------------------+-------------------+-------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura changed the title improve snapshot store apis improve snapshot store related apis Apr 21, 2022
@DanielBadura DanielBadura merged commit d3d011a into 2.0.x Apr 21, 2022
@DanielBadura DanielBadura deleted the improve-snapshot-store-apis branch April 21, 2022 08:50
@DavidBadura DavidBadura added the enhancement New feature or request label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants