Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove benchmark workflow for base, since it cannot diff it right now #216

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

DanielBadura
Copy link
Member

@DanielBadura DanielBadura commented Apr 21, 2022

Right now, the benchmark workflow only work on PR branches. So i deactivated it for now for the base branches. But maybe we should add some more logic here so it can run on these?

@github-actions
Copy link

Hello 👋

here is the most recent benchmark result:

LoadEventsBench
===============

Average iteration times by variant

81.8ms    │ ▂█ 
71.5ms    │ ██ 
61.3ms    │ ██ 
51.1ms    │ ██ 
40.9ms    │ ██ 
30.7ms    │ ██ 
20.4ms    │ ██ 
10.2ms    │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

Memory by variant

19.1mb    │ ██ 
16.7mb    │ ██ 
14.3mb    │ ██ 
11.9mb    │ ██ 
9.5mb     │ ██ 
7.1mb     │ ██ 
4.8mb     │ ██ 
2.4mb     │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

+--------------------+-------------------+-------------------+-----------------+------------+
|                    | time (kde mode)                       | memory                       |
+--------------------+-------------------+-------------------+-----------------+------------+
| subject            | Tag: <current>    | Tag: base         | Tag: <current>  | Tag: base  |
+--------------------+-------------------+-------------------+-----------------+------------+
| benchLoadEvents () | 73.329ms (±1.00%) | 81.753ms (±0.05%) | 19.066mb        | 19.066mb   |
+--------------------+-------------------+-------------------+-----------------+------------+

LoadEventsWithSnapshotsBench
============================

Average iteration times by variant

264.8μs   │ ▁█ 
231.7μs   │ ██ 
198.6μs   │ ██ 
165.5μs   │ ██ 
132.4μs   │ ██ 
99.3μs    │ ██ 
66.2μs    │ ██ 
33.1μs    │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

Memory by variant

13.1mb    │ ██ 
11.4mb    │ ██ 
9.8mb     │ ██ 
8.2mb     │ ██ 
6.5mb     │ ██ 
4.9mb     │ ██ 
3.3mb     │ ██ 
1.6mb     │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

+--------------------+--------------------+--------------------+-----------------+------------+
|                    | time (kde mode)                         | memory                       |
+--------------------+--------------------+--------------------+-----------------+------------+
| subject            | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+--------------------+--------------------+--------------------+-----------------+------------+
| benchLoadEvents () | 233.600μs (±0.43%) | 264.800μs (±2.64%) | 13.069mb        | 13.069mb   |
+--------------------+--------------------+--------------------+-----------------+------------+

WriteEventsBench
================

Average iteration times by variant

35.7ms    │    ▂█ 
31.3ms    │    ██ 
26.8ms    │    ██ 
22.3ms    │    ██ 
17.9ms    │    ██ 
13.4ms    │    ██ 
8.9ms     │    ██ 
4.5ms     │ ▃▂ ██ 
          └───────
            1  2  

[█ <current>] [█ base] 

1: benchSaveOneEvent    2: benchSaveAfterThous᠁ 

Memory by variant

7.0mb     │ ▃▃ ██ 
6.1mb     │ ██ ██ 
5.2mb     │ ██ ██ 
4.4mb     │ ██ ██ 
3.5mb     │ ██ ██ 
2.6mb     │ ██ ██ 
1.7mb     │ ██ ██ 
871.4kb   │ ██ ██ 
          └───────
            1  2  

[█ <current>] [█ base] 

1: benchSaveOneEvent    2: benchSaveAfterThous᠁ 

+---------------------------------+-------------------+-------------------+-----------------+------------+
|                                 | time (kde mode)                       | memory                       |
+---------------------------------+-------------------+-------------------+-----------------+------------+
| subject                         | Tag: <current>    | Tag: base         | Tag: <current>  | Tag: base  |
+---------------------------------+-------------------+-------------------+-----------------+------------+
| benchSaveOneEvent ()            | 1.212ms (±13.61%) | 1.083ms (±2.33%)  | 6.336mb         | 6.336mb    |
| benchSaveAfterThousandEvents () | 32.169ms (±0.85%) | 35.715ms (±0.12%) | 6.971mb         | 6.971mb    |
+---------------------------------+-------------------+-------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DanielBadura DanielBadura marked this pull request as ready for review April 25, 2022 11:53
@DanielBadura DanielBadura changed the title Fix benchmark workflow so it's not failing on the base Remove benchmark workflow for base, since it cannot diff it right now Apr 25, 2022
@DavidBadura DavidBadura merged commit 87e823a into 2.0.x Apr 25, 2022
@DanielBadura DanielBadura deleted the DanielBadura-patch-1 branch April 25, 2022 11:55
@DanielBadura DanielBadura added this to the 2.0.0 milestone May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants