Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcaster not required in serializer #250

Merged
merged 2 commits into from
May 9, 2022

Conversation

DanielBadura
Copy link
Member

fix #249

@github-actions
Copy link

github-actions bot commented May 9, 2022

Hello 👋

here is the most recent benchmark result:

WriteEventsBench
================

Average iteration times by variant

39.0ms    │    █▇ 
34.2ms    │    ██ 
29.3ms    │    ██ 
24.4ms    │    ██ 
19.5ms    │    ██ 
14.6ms    │    ██ 
9.8ms     │    ██ 
4.9ms     │ ▃▄ ██ 
          └───────
            1  2  

[█ <current>] [█ base] 

1: benchSaveOneEvent    2: benchSaveAfterThous᠁ 

Memory by variant

7.4mb     │    ██ 
6.5mb     │ ██ ██ 
5.5mb     │ ██ ██ 
4.6mb     │ ██ ██ 
3.7mb     │ ██ ██ 
2.8mb     │ ██ ██ 
1.8mb     │ ██ ██ 
922.6kb   │ ██ ██ 
          └───────
            1  2  

[█ <current>] [█ base] 

1: benchSaveOneEvent    2: benchSaveAfterThous᠁ 

+---------------------------------+-------------------+-------------------+-----------------+------------+
|                                 | time (kde mode)                       | memory                       |
+---------------------------------+-------------------+-------------------+-----------------+------------+
| subject                         | Tag: <current>    | Tag: base         | Tag: <current>  | Tag: base  |
+---------------------------------+-------------------+-------------------+-----------------+------------+
| benchSaveOneEvent ()            | 1.366ms (±3.97%)  | 1.897ms (±27.67%) | 6.386mb         | 6.390mb    |
| benchSaveAfterThousandEvents () | 39.049ms (±6.17%) | 38.316ms (±2.02%) | 7.377mb         | 7.381mb    |
+---------------------------------+-------------------+-------------------+-----------------+------------+

LoadEventsBench
===============

Average iteration times by variant

90.3ms    │ ▄█ 
79.0ms    │ ██ 
67.8ms    │ ██ 
56.5ms    │ ██ 
45.2ms    │ ██ 
33.9ms    │ ██ 
22.6ms    │ ██ 
11.3ms    │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

Memory by variant

22.4mb    │ ██ 
19.6mb    │ ██ 
16.8mb    │ ██ 
14.0mb    │ ██ 
11.2mb    │ ██ 
8.4mb     │ ██ 
5.6mb     │ ██ 
2.8mb     │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

+--------------------+-------------------+-------------------+-----------------+------------+
|                    | time (kde mode)                       | memory                       |
+--------------------+-------------------+-------------------+-----------------+------------+
| subject            | Tag: <current>    | Tag: base         | Tag: <current>  | Tag: base  |
+--------------------+-------------------+-------------------+-----------------+------------+
| benchLoadEvents () | 84.223ms (±0.98%) | 90.342ms (±0.40%) | 22.397mb        | 22.402mb   |
+--------------------+-------------------+-------------------+-----------------+------------+

LoadEventsWithSnapshotsBench
============================

Average iteration times by variant

263.5μs   │ ██ 
230.6μs   │ ██ 
197.6μs   │ ██ 
164.7μs   │ ██ 
131.8μs   │ ██ 
98.8μs    │ ██ 
65.9μs    │ ██ 
32.9μs    │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

Memory by variant

16.9mb    │ ██ 
14.8mb    │ ██ 
12.7mb    │ ██ 
10.6mb    │ ██ 
8.5mb     │ ██ 
6.4mb     │ ██ 
4.2mb     │ ██ 
2.1mb     │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

+--------------------+--------------------+--------------------+-----------------+------------+
|                    | time (kde mode)                         | memory                       |
+--------------------+--------------------+--------------------+-----------------+------------+
| subject            | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+--------------------+--------------------+--------------------+-----------------+------------+
| benchLoadEvents () | 263.505μs (±0.91%) | 263.049μs (±0.21%) | 16.935mb        | 16.939mb   |
+--------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura linked an issue May 9, 2022 that may be closed by this pull request
@DanielBadura DanielBadura self-assigned this May 9, 2022
@DanielBadura DanielBadura added the enhancement New feature or request label May 9, 2022
@DanielBadura DanielBadura added this to the 2.0.0 milestone May 9, 2022
@DavidBadura DavidBadura merged commit 74dea00 into 2.0.x May 9, 2022
@DavidBadura DavidBadura deleted the upcaster-not-required-in-serializer branch May 9, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make upcaster optional in event serializer
2 participants