Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all deprecations #350

Merged
merged 1 commit into from
Dec 31, 2022
Merged

Remove all deprecations #350

merged 1 commit into from
Dec 31, 2022

Conversation

DavidBadura
Copy link
Member

No description provided.

@DavidBadura DavidBadura added this to the 3.0.0 milestone Dec 28, 2022
@github-actions
Copy link

github-actions bot commented Dec 28, 2022

Hello 👋

here is the most recent benchmark result:

LoadEventsBench
===============

Average iteration times by variant

104.7ms   │ ██ 
91.6ms    │ ██ 
78.5ms    │ ██ 
65.4ms    │ ██ 
52.3ms    │ ██ 
39.3ms    │ ██ 
26.2ms    │ ██ 
13.1ms    │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

Memory by variant

23.4mb    │ ██ 
20.5mb    │ ██ 
17.6mb    │ ██ 
14.6mb    │ ██ 
11.7mb    │ ██ 
8.8mb     │ ██ 
5.9mb     │ ██ 
2.9mb     │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

+--------------------+--------------------+--------------------+-----------------+------------+
|                    | time (kde mode)                         | memory                       |
+--------------------+--------------------+--------------------+-----------------+------------+
| subject            | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+--------------------+--------------------+--------------------+-----------------+------------+
| benchLoadEvents () | 104.673ms (±0.57%) | 103.522ms (±1.04%) | 23.426mb        | 23.428mb   |
+--------------------+--------------------+--------------------+-----------------+------------+

WriteEventsBench
================

Average iteration times by variant

50.5ms    │    ██ 
44.2ms    │    ██ 
37.9ms    │    ██ 
31.5ms    │    ██ 
25.2ms    │    ██ 
18.9ms    │    ██ 
12.6ms    │    ██ 
6.3ms     │ ▂▃ ██ 
          └───────
            1  2  

[█ <current>] [█ base] 

1: benchSaveOneEvent    2: benchSaveAfterThous᠁ 

Memory by variant

7.4mb     │ ▃▃ ██ 
6.5mb     │ ██ ██ 
5.6mb     │ ██ ██ 
4.6mb     │ ██ ██ 
3.7mb     │ ██ ██ 
2.8mb     │ ██ ██ 
1.9mb     │ ██ ██ 
927.6kb   │ ██ ██ 
          └───────
            1  2  

[█ <current>] [█ base] 

1: benchSaveOneEvent    2: benchSaveAfterThous᠁ 

+---------------------------------+-------------------+-------------------+-----------------+------------+
|                                 | time (kde mode)                       | memory                       |
+---------------------------------+-------------------+-------------------+-----------------+------------+
| subject                         | Tag: <current>    | Tag: base         | Tag: <current>  | Tag: base  |
+---------------------------------+-------------------+-------------------+-----------------+------------+
| benchSaveOneEvent ()            | 1.218ms (±0.67%)  | 1.698ms (±34.32%) | 6.754mb         | 6.789mb    |
| benchSaveAfterThousandEvents () | 50.469ms (±0.29%) | 50.376ms (±1.47%) | 7.419mb         | 7.421mb    |
+---------------------------------+-------------------+-------------------+-----------------+------------+

LoadEventsWithSnapshotsBench
============================

Average iteration times by variant

322.6μs   │ ▇█ 
282.3μs   │ ██ 
241.9μs   │ ██ 
201.6μs   │ ██ 
161.3μs   │ ██ 
121.0μs   │ ██ 
80.6μs    │ ██ 
40.3μs    │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

Memory by variant

13.6mb    │ ██ 
11.9mb    │ ██ 
10.2mb    │ ██ 
8.5mb     │ ██ 
6.8mb     │ ██ 
5.1mb     │ ██ 
3.4mb     │ ██ 
1.7mb     │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

+--------------------+--------------------+--------------------+-----------------+------------+
|                    | time (kde mode)                         | memory                       |
+--------------------+--------------------+--------------------+-----------------+------------+
| subject            | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+--------------------+--------------------+--------------------+-----------------+------------+
| benchLoadEvents () | 313.474μs (±3.91%) | 322.580μs (±4.76%) | 13.561mb        | 13.563mb   |
+--------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura marked this pull request as ready for review December 31, 2022 11:56
@DavidBadura DavidBadura merged commit 4f74b47 into 3.0.x Dec 31, 2022
@DavidBadura DavidBadura deleted the remove-deprecations branch December 31, 2022 12:04
@DanielBadura DanielBadura changed the title remove deprecations Remove all deprecations Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant