Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated projector listener #403

Merged
merged 7 commits into from
Aug 10, 2023

Conversation

DavidBadura
Copy link
Member

No description provided.

@DavidBadura DavidBadura added this to the 3.0.0 milestone Aug 5, 2023
@DavidBadura DavidBadura force-pushed the remove-deprecated-projector-listener branch from a126e20 to f1ef55d Compare August 5, 2023 15:14
@DavidBadura DavidBadura changed the title remove deprecated projector listener replace deprecated projector listener Aug 5, 2023
@github-actions
Copy link

github-actions bot commented Aug 5, 2023

Hello 👋

here is the most recent benchmark result:

WriteEventsBench
================

Average iteration times by variant

64.7ms    │    █  
56.6ms    │    █  
48.5ms    │    ██ 
40.5ms    │    ██ 
32.4ms    │    ██ 
24.3ms    │    ██ 
16.2ms    │    ██ 
8.1ms     │ ▂▂ ██ 
          └───────
            1  2  

[█ <current>] [█ base] 

1: benchSaveOneEvent    2: benchSaveAfterThous᠁ 

Memory by variant

7.8mb     │ ▃  █▅ 
6.9mb     │ ██ ██ 
5.9mb     │ ██ ██ 
4.9mb     │ ██ ██ 
3.9mb     │ ██ ██ 
2.9mb     │ ██ ██ 
2.0mb     │ ██ ██ 
980.9kb   │ ██ ██ 
          └───────
            1  2  

[█ <current>] [█ base] 

1: benchSaveOneEvent    2: benchSaveAfterThous᠁ 

+---------------------------------+-------------------+-------------------+-----------------+------------+
|                                 | time (kde mode)                       | memory                       |
+---------------------------------+-------------------+-------------------+-----------------+------------+
| subject                         | Tag: <current>    | Tag: base         | Tag: <current>  | Tag: base  |
+---------------------------------+-------------------+-------------------+-----------------+------------+
| benchSaveOneEvent ()            | 1.425ms (±10.92%) | 1.046ms (±4.33%)  | 7.215mb         | 6.806mb    |
| benchSaveAfterThousandEvents () | 64.728ms (±0.77%) | 47.979ms (±0.01%) | 7.847mb         | 7.432mb    |
+---------------------------------+-------------------+-------------------+-----------------+------------+

LoadEventsBench
===============

Average iteration times by variant

125.9ms   │ ▇█ 
110.2ms   │ ██ 
94.4ms    │ ██ 
78.7ms    │ ██ 
63.0ms    │ ██ 
47.2ms    │ ██ 
31.5ms    │ ██ 
15.7ms    │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

Memory by variant

13.5mb    │ ██ 
11.8mb    │ ██ 
10.1mb    │ ██ 
8.5mb     │ ██ 
6.8mb     │ ██ 
5.1mb     │ ██ 
3.4mb     │ ██ 
1.7mb     │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

+--------------------+--------------------+--------------------+-----------------+------------+
|                    | time (kde mode)                         | memory                       |
+--------------------+--------------------+--------------------+-----------------+------------+
| subject            | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+--------------------+--------------------+--------------------+-----------------+------------+
| benchLoadEvents () | 123.098ms (±1.36%) | 125.922ms (±2.06%) | 13.523mb        | 13.523mb   |
+--------------------+--------------------+--------------------+-----------------+------------+

LoadEventsWithSnapshotsBench
============================

Average iteration times by variant

316.9μs   │ ▇█ 
277.3μs   │ ██ 
237.7μs   │ ██ 
198.1μs   │ ██ 
158.4μs   │ ██ 
118.8μs   │ ██ 
79.2μs    │ ██ 
39.6μs    │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

Memory by variant

13.6mb    │ ██ 
11.9mb    │ ██ 
10.2mb    │ ██ 
8.5mb     │ ██ 
6.8mb     │ ██ 
5.1mb     │ ██ 
3.4mb     │ ██ 
1.7mb     │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

+--------------------+--------------------+--------------------+-----------------+------------+
|                    | time (kde mode)                         | memory                       |
+--------------------+--------------------+--------------------+-----------------+------------+
| subject            | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+--------------------+--------------------+--------------------+-----------------+------------+
| benchLoadEvents () | 310.601μs (±0.13%) | 316.889μs (±1.83%) | 13.553mb        | 13.553mb   |
+--------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura merged commit f1d8f53 into 3.0.x Aug 10, 2023
@DavidBadura DavidBadura deleted the remove-deprecated-projector-listener branch August 10, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants