Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use aggregate name in message to decouple components #487

Merged
merged 2 commits into from
Feb 6, 2024
Merged

use aggregate name in message to decouple components #487

merged 2 commits into from
Feb 6, 2024

Conversation

DavidBadura
Copy link
Member

The aggregate class was removed from the message and replaced with the aggregate name. This means that other components are more decoupled from the aggregate.

@DavidBadura DavidBadura added enhancement New feature or request BC-Break labels Feb 3, 2024
@DavidBadura DavidBadura added this to the 3.0.0 milestone Feb 3, 2024
@DavidBadura DavidBadura force-pushed the use-aggregate-name-in-message branch 2 times, most recently from 2b92981 to 8bbda20 Compare February 4, 2024 09:43
@DavidBadura DavidBadura force-pushed the use-aggregate-name-in-message branch from 8bbda20 to ef1cc8a Compare February 6, 2024 08:07
@DavidBadura DavidBadura force-pushed the use-aggregate-name-in-message branch from d051165 to e19edbf Compare February 6, 2024 08:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024 •
edited
Loading

Hello 👋

here is the most recent benchmark result: 

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 2.369ms (±0.00%)   | 2.667ms (±0.00%)   | 38.070mb        | 38.085mb   |
| benchSave10000Events () | 322.312ms (±0.00%) | 324.459ms (±0.00%) | 38.367mb        | 38.383mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000EventsMissingSnapshot () | 121.250ms (±0.00%) | 124.627ms (±0.00%) | 34.703mb        | 34.723mb   |
| benchLoad10000Events ()                | 200.650μs (±0.00%) | 200.450μs (±0.00%) | 34.703mb        | 34.723mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SyncProjectionistBench
======================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchSave1Event ()      | 1.598ms (±0.00%)   | 1.458ms (±0.00%)   | 7.615mb         | 7.636mb    |
| benchSave10000Events () | 446.177ms (±0.00%) | 457.943ms (±0.00%) | 35.574mb        | 35.589mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()                | 121.075ms (±0.00%) | 122.251ms (±0.00%) | 34.686mb        | 34.702mb   |
| benchSave1Event ()                     | 974.500μs (±0.00%) | 1.405ms (±0.00%)   | 34.686mb        | 34.702mb   |
| benchSave10000Events ()                | 282.583ms (±0.00%) | 292.476ms (±0.00%) | 34.954mb        | 34.969mb   |
| benchSave10000Aggregates ()            | 14.430s (±0.00%)   | 14.502s (±0.00%)   | 34.686mb        | 34.702mb   |
| benchSave10000AggregatesTransaction () | 835.966ms (±0.00%) | 832.186ms (±0.00%) | 34.686mb        | 34.702mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura force-pushed the use-aggregate-name-in-message branch from e19edbf to 46328d2 Compare February 6, 2024 08:33
@DavidBadura DavidBadura marked this pull request as ready for review February 6, 2024 08:34
DanielBadura
DanielBadura approved these changes Feb 6, 2024 •
edited
Loading
View reviewed changes
@DavidBadura DavidBadura merged commit 9b672e8 into 3.0.x Feb 6, 2024
32 of 33 checks passed
@DavidBadura DavidBadura deleted the use-aggregate-name-in-message branch February 6, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielBadura DanielBadura DanielBadura approved these changes

Assignees
No one assigned
Labels
BC-Break enhancement New feature or request
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidBadura @DanielBadura