Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Message with headers #494

Merged
merged 8 commits into from
Feb 9, 2024
Merged

Update Message with headers #494

merged 8 commits into from
Feb 9, 2024

Conversation

DanielBadura
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024 •
edited
Loading

Hello 👋

here is the most recent benchmark result: 

SyncProjectionistBench
======================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchSave1Event ()      | 1.549ms (±0.00%)   | 2.165ms (±0.00%)   | 7.634mb         | 7.628mb    |
| benchSave10000Events () | 565.239ms (±0.00%) | 491.250ms (±0.00%) | 41.988mb        | 35.580mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 2.790ms (±0.00%)   | 2.434ms (±0.00%)   | 44.544mb        | 38.074mb   |
| benchSave10000Events () | 375.432ms (±0.00%) | 347.866ms (±0.00%) | 44.841mb        | 38.372mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000EventsMissingSnapshot () | 164.353ms (±0.00%) | 125.584ms (±0.00%) | 41.114mb        | 34.707mb   |
| benchLoad10000Events ()                | 201.100μs (±0.00%) | 199.850μs (±0.00%) | 41.114mb        | 34.707mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()                | 164.895ms (±0.00%) | 127.377ms (±0.00%) | 41.097mb        | 34.690mb   |
| benchSave1Event ()                     | 1.250ms (±0.00%)   | 1.329ms (±0.00%)   | 41.097mb        | 34.690mb   |
| benchSave10000Events ()                | 360.011ms (±0.00%) | 293.775ms (±0.00%) | 41.364mb        | 34.958mb   |
| benchSave10000Aggregates ()            | 13.552s (±0.00%)   | 14.003s (±0.00%)   | 41.097mb        | 34.690mb   |
| benchSave10000AggregatesTransaction () | 947.483ms (±0.00%) | 835.267ms (±0.00%) | 41.097mb        | 34.690mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DanielBadura DanielBadura force-pushed the message-header-rewrite branch from 833af7e to 848c9c1 Compare February 7, 2024 10:11
DanielBadura
DanielBadura commented Feb 8, 2024
View reviewed changes
src/EventBus/Message.php
Comment on lines +24 to +31
* @phpstan-type Headers = array{
* aggregateName?: string,
* aggregateId?: string,
* playhead?: positive-int,
* recordedOn?: DateTimeImmutable,
* newStreamStart?: bool,
* archived?: bool
* }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a extra type for PHPStan for now since unsealed array as a feature does not exist there. PHPStan only fixed syntax crashes for now with the ... but type resolution is less useful as with this type we have here imho.

@DanielBadura DanielBadura marked this pull request as ready for review February 8, 2024 10:56
@DanielBadura DanielBadura self-assigned this Feb 8, 2024
@DanielBadura DanielBadura added the enhancement New feature or request label Feb 8, 2024
@DanielBadura DanielBadura added this to the 3.0.0 milestone Feb 8, 2024
@DavidBadura DavidBadura merged commit da33974 into 3.0.x Feb 9, 2024
32 of 33 checks passed
@DavidBadura DavidBadura deleted the message-header-rewrite branch February 9, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidBadura DavidBadura DavidBadura approved these changes

Assignees

@DanielBadura DanielBadura

Labels
BC-Break enhancement New feature or request
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielBadura @DavidBadura