-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade hydrator & use new auto detect feature #510
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
I think we also should update the BenchmarkTest Fixtures to reflect the performance changes - which I expect to be low to none. |
Then the benchmark should be added to the hydrator, what do you think? |
DavidBadura
force-pushed
the
upgrade-hydrator
branch
from
February 26, 2024 08:34
16c8567
to
62c7346
Compare
DavidBadura
force-pushed
the
upgrade-hydrator
branch
from
February 26, 2024 08:39
62c7346
to
db0bd3b
Compare
I have now rewrite everything to the new system, including in the benchmark test. |
DanielBadura
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs patchlevel/hydrator#37