Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade hydrator & use new auto detect feature #510

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

DavidBadura
Copy link
Member

@DavidBadura DavidBadura added this to the 3.0.0 milestone Feb 25, 2024
@DavidBadura DavidBadura added the enhancement New feature or request label Feb 25, 2024
Copy link

github-actions bot commented Feb 25, 2024

Hello 👋

here is the most recent benchmark result:

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()                | 159.366ms (±0.00%) | 162.723ms (±0.00%) | 41.107mb        | 41.097mb   |
| benchSave1Event ()                     | 1.058ms (±0.00%)   | 1.134ms (±0.00%)   | 41.107mb        | 41.097mb   |
| benchSave10000Events ()                | 334.929ms (±0.00%) | 341.122ms (±0.00%) | 41.374mb        | 41.364mb   |
| benchSave10000Aggregates ()            | 11.031s (±0.00%)   | 11.953s (±0.00%)   | 41.107mb        | 41.097mb   |
| benchSave10000AggregatesTransaction () | 935.356ms (±0.00%) | 938.480ms (±0.00%) | 41.107mb        | 41.097mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000EventsMissingSnapshot () | 161.401ms (±0.00%) | 160.743ms (±0.00%) | 41.124mb        | 41.114mb   |
| benchLoad10000Events ()                | 201.200μs (±0.00%) | 359.600μs (±0.00%) | 41.124mb        | 41.114mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 2.778ms (±0.00%)   | 2.737ms (±0.00%)   | 44.555mb        | 44.544mb   |
| benchSave10000Events () | 364.396ms (±0.00%) | 367.184ms (±0.00%) | 44.852mb        | 44.842mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DanielBadura
Copy link
Member

I think we also should update the BenchmarkTest Fixtures to reflect the performance changes - which I expect to be low to none.

@DavidBadura
Copy link
Member Author

Then the benchmark should be added to the hydrator, what do you think?

@DavidBadura
Copy link
Member Author

I have now rewrite everything to the new system, including in the benchmark test.

@DavidBadura DavidBadura marked this pull request as ready for review February 26, 2024 08:40
@DavidBadura DavidBadura mentioned this pull request Feb 26, 2024
19 tasks
@DavidBadura DavidBadura merged commit 5f3178a into 3.0.x Feb 26, 2024
32 of 33 checks passed
@DavidBadura DavidBadura deleted the upgrade-hydrator branch February 26, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants