Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split boot method into boot and setup in subscription engine #531

Merged
merged 2 commits into from
Mar 12, 2024
Merged

split boot method into boot and setup in subscription engine #531

merged 2 commits into from
Mar 12, 2024

Conversation

DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Mar 9, 2024 •
edited
Loading

@DavidBadura DavidBadura added this to the 3.0.0 milestone Mar 9, 2024
@DavidBadura DavidBadura added enhancement New feature or request BC-Break labels Mar 9, 2024
@DavidBadura DavidBadura requested a review from DanielBadura March 9, 2024 14:59
@DavidBadura DavidBadura force-pushed the add-setup-method branch 2 times, most recently from 4521050 to 43687f9 Compare March 9, 2024 15:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2024 •
edited
Loading

Hello 👋

here is the most recent benchmark result: 

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000EventsMissingSnapshot () | 165.616ms (±0.00%) | 168.279ms (±0.00%) | 38.664mb        | 38.650mb   |
| benchLoad10000Events ()                | 531.300μs (±0.00%) | 524.700μs (±0.00%) | 38.664mb        | 38.650mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()                | 169.178ms (±0.00%) | 167.178ms (±0.00%) | 38.667mb        | 38.653mb   |
| benchSave1Event ()                     | 889.800μs (±0.00%) | 921.500μs (±0.00%) | 38.667mb        | 38.653mb   |
| benchSave10000Events ()                | 496.587ms (±0.00%) | 496.479ms (±0.00%) | 38.933mb        | 38.919mb   |
| benchSave10000Aggregates ()            | 9.285s (±0.00%)    | 9.520s (±0.00%)    | 38.667mb        | 38.653mb   |
| benchSave10000AggregatesTransaction () | 7.592s (±0.00%)    | 7.514s (±0.00%)    | 38.667mb        | 38.653mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------------+------------+
|                           | time (kde mode)                   | memory                       |
+---------------------------+-----------------+-----------------+-----------------+------------+
| subject                   | Tag: <current>  | Tag: base       | Tag: <current>  | Tag: base  |
+---------------------------+-----------------+-----------------+-----------------+------------+
| benchHandle10000Events () | 3.276s (±0.00%) | 3.276s (±0.00%) | 39.066mb        | 39.052mb   |
+---------------------------+-----------------+-----------------+-----------------+------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 5.591ms (±0.00%)   | 5.553ms (±0.00%)   | 42.532mb        | 42.518mb   |
| benchSave10000Events () | 637.347ms (±0.00%) | 657.673ms (±0.00%) | 42.809mb        | 42.796mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura force-pushed the add-setup-method branch 2 times, most recently from b2d0c69 to 2b58819 Compare March 12, 2024 11:18
@DavidBadura DavidBadura marked this pull request as ready for review March 12, 2024 11:18
@DavidBadura DavidBadura merged commit 437be5d into 3.0.x Mar 12, 2024
32 of 33 checks passed
@DavidBadura DavidBadura deleted the add-setup-method branch March 12, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielBadura DanielBadura DanielBadura approved these changes

Assignees
No one assigned
Labels
BC-Break enhancement New feature or request
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidBadura @DanielBadura