Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace pipeline with subscription engine #540

Merged
merged 2 commits into from
Mar 25, 2024
Merged

replace pipeline with subscription engine #540

merged 2 commits into from
Mar 25, 2024

Conversation

DavidBadura
Copy link
Member

  • remove pipeline namespace
  • move middlewares into message namespace

@DavidBadura DavidBadura marked this pull request as draft March 13, 2024 12:17
@DavidBadura DavidBadura added enhancement New feature or request BC-Break labels Mar 13, 2024
@DavidBadura DavidBadura added this to the 3.0.0 milestone Mar 13, 2024
@DavidBadura DavidBadura changed the title replace pipeline with subscription replace pipeline with subscription engine Mar 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 13, 2024 •
edited
Loading

Hello 👋

here is the most recent benchmark result: 

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------------+------------+
|                           | time (kde mode)                   | memory                       |
+---------------------------+-----------------+-----------------+-----------------+------------+
| subject                   | Tag: <current>  | Tag: base       | Tag: <current>  | Tag: base  |
+---------------------------+-----------------+-----------------+-----------------+------------+
| benchHandle10000Events () | 3.310s (±0.00%) | 3.305s (±0.00%) | 37.764mb        | 37.764mb   |
+---------------------------+-----------------+-----------------+-----------------+------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 5.619ms (±0.00%)   | 5.891ms (±0.00%)   | 41.203mb        | 41.203mb   |
| benchSave10000Events () | 611.372ms (±0.00%) | 595.474ms (±0.00%) | 41.222mb        | 41.222mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()                | 157.581ms (±0.00%) | 156.671ms (±0.00%) | 37.324mb        | 37.324mb   |
| benchSave1Event ()                     | 969.000μs (±0.00%) | 949.000μs (±0.00%) | 37.324mb        | 37.324mb   |
| benchSave10000Events ()                | 418.605ms (±0.00%) | 416.298ms (±0.00%) | 37.333mb        | 37.333mb   |
| benchSave10000Aggregates ()            | 9.315s (±0.00%)    | 9.186s (±0.00%)    | 37.324mb        | 37.324mb   |
| benchSave10000AggregatesTransaction () | 7.462s (±0.00%)    | 7.485s (±0.00%)    | 37.325mb        | 37.325mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000EventsMissingSnapshot () | 158.421ms (±0.00%) | 160.943ms (±0.00%) | 37.343mb        | 37.343mb   |
| benchLoad10000Events ()                | 534.400μs (±0.00%) | 535.800μs (±0.00%) | 37.343mb        | 37.343mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura force-pushed the replace-pipeline branch 2 times, most recently from 4b1f165 to 7e73356 Compare March 25, 2024 10:50
@DavidBadura DavidBadura marked this pull request as ready for review March 25, 2024 10:52
@DavidBadura DavidBadura merged commit 4b98344 into 3.0.x Mar 25, 2024
34 of 36 checks passed
@DavidBadura DavidBadura deleted the replace-pipeline branch March 25, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielBadura DanielBadura DanielBadura approved these changes

Assignees
No one assigned
Labels
BC-Break enhancement New feature or request
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidBadura @DanielBadura