Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw stream close exception in array stream implementation #556

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

DavidBadura
Copy link
Member

... and fix subscription engine run

@DavidBadura DavidBadura added the bug Something isn't working label Mar 27, 2024
@DavidBadura DavidBadura added this to the 3.0.0 milestone Mar 27, 2024
Copy link

github-actions bot commented Mar 27, 2024

Hello 👋

here is the most recent benchmark result:

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------------+------------+
|                           | time (kde mode)                   | memory                       |
+---------------------------+-----------------+-----------------+-----------------+------------+
| subject                   | Tag: <current>  | Tag: base       | Tag: <current>  | Tag: base  |
+---------------------------+-----------------+-----------------+-----------------+------------+
| benchHandle10000Events () | 3.306s (±0.00%) | 3.297s (±0.00%) | 37.782mb        | 37.782mb   |
+---------------------------+-----------------+-----------------+-----------------+------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()                | 230.755ms (±0.00%) | 236.075ms (±0.00%) | 39.996mb        | 39.994mb   |
| benchSave1Event ()                     | 1.357ms (±0.00%)   | 1.477ms (±0.00%)   | 39.996mb        | 39.994mb   |
| benchSave10000Events ()                | 466.459ms (±0.00%) | 491.982ms (±0.00%) | 39.998mb        | 39.996mb   |
| benchSave10000Aggregates ()            | 13.926s (±0.00%)   | 13.977s (±0.00%)   | 39.996mb        | 39.994mb   |
| benchSave10000AggregatesTransaction () | 11.688s (±0.00%)   | 11.824s (±0.00%)   | 40.497mb        | 40.495mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 5.362ms (±0.00%)   | 5.573ms (±0.00%)   | 41.234mb        | 41.234mb   |
| benchSave10000Events () | 563.863ms (±0.00%) | 567.217ms (±0.00%) | 41.245mb        | 41.245mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()                | 163.113ms (±0.00%) | 166.463ms (±0.00%) | 37.343mb        | 37.343mb   |
| benchSave1Event ()                     | 945.500μs (±0.00%) | 897.600μs (±0.00%) | 37.343mb        | 37.343mb   |
| benchSave10000Events ()                | 401.535ms (±0.00%) | 406.964ms (±0.00%) | 37.343mb        | 37.343mb   |
| benchSave10000Aggregates ()            | 10.004s (±0.00%)   | 9.612s (±0.00%)    | 37.343mb        | 37.343mb   |
| benchSave10000AggregatesTransaction () | 7.478s (±0.00%)    | 7.428s (±0.00%)    | 37.343mb        | 37.343mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000EventsMissingSnapshot () | 161.496ms (±0.00%) | 159.413ms (±0.00%) | 37.361mb        | 37.361mb   |
| benchLoad10000Events ()                | 526.500μs (±0.00%) | 536.700μs (±0.00%) | 37.361mb        | 37.361mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura merged commit a985655 into 3.0.x Mar 27, 2024
35 of 36 checks passed
@DavidBadura DavidBadura deleted the fix-stream-close branch March 27, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants