Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw an exception if duplicated subscriber id exists #586

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

DavidBadura
Copy link
Member

No description provided.

@DavidBadura DavidBadura added the bug Something isn't working label Apr 21, 2024
@DavidBadura DavidBadura added this to the 3.0.0 milestone Apr 21, 2024
@DavidBadura DavidBadura enabled auto-merge April 21, 2024 07:07
Copy link

Hello 👋

here is the most recent benchmark result:

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.802ms (±0.00%)   | 6.663ms (±0.00%)   | -27.94%   | 37.572mb        | 37.578mb   | -0.02%      |
| benchSave10000Events () | 339.044ms (±0.00%) | 363.710ms (±0.00%) | -6.78%    | 37.070mb        | 37.579mb   | -1.35%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 940.500μs (±0.00%) | 945.900μs (±0.00%) | -0.57%    | 33.762mb        | 33.762mb   | 0.00%       |
| benchLoad10000Events ()                | 52.185ms (±0.00%)  | 49.853ms (±0.00%)  | +4.68%    | 33.762mb        | 33.762mb   | 0.00%       |
| benchSave1Event ()                     | 1.092ms (±0.00%)   | 1.256ms (±0.00%)   | -13.03%   | 33.762mb        | 33.762mb   | 0.00%       |
| benchSave10000Events ()                | 213.518ms (±0.00%) | 220.037ms (±0.00%) | -2.96%    | 33.764mb        | 33.764mb   | 0.00%       |
| benchSave10000Aggregates ()            | 9.550s (±0.00%)    | 9.075s (±0.00%)    | +5.23%    | 33.763mb        | 33.763mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 6.860s (±0.00%)    | 6.850s (±0.00%)    | +0.15%    | 33.763mb        | 33.763mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 51.300ms (±0.00%)  | 50.369ms (±0.00%)  | +1.85%    | 33.763mb        | 33.763mb   | 0.00%       |
| benchLoad10000Events ()                | 884.200μs (±0.00%) | 901.100μs (±0.00%) | -1.88%    | 33.763mb        | 33.763mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 869.400μs (±0.00%) | 861.400μs (±0.00%) | +0.93%    | 34.892mb        | 34.892mb   | 0.00%       |
| benchLoad10000Events ()                | 81.470ms (±0.00%)  | 84.401ms (±0.00%)  | -3.47%    | 34.892mb        | 34.892mb   | 0.00%       |
| benchSave1Event ()                     | 1.559ms (±0.00%)   | 1.526ms (±0.00%)   | +2.10%    | 34.892mb        | 34.892mb   | 0.00%       |
| benchSave10000Events ()                | 244.034ms (±0.00%) | 244.152ms (±0.00%) | -0.05%    | 34.894mb        | 34.894mb   | 0.00%       |
| benchSave10000Aggregates ()            | 13.889s (±0.00%)   | 13.679s (±0.00%)   | +1.54%    | 34.892mb        | 34.892mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 10.857s (±0.00%)   | 10.844s (±0.00%)   | +0.13%    | 35.394mb        | 35.394mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.068s (±0.00%) | 3.060s (±0.00%) | +0.26%    | 34.162mb        | 34.162mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura merged commit c67f4c6 into 3.0.x Apr 21, 2024
35 of 36 checks passed
@DanielBadura DanielBadura deleted the fix-duplicated-subscriber-id branch April 21, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants