Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Experimental] Child Aggregates #614

Merged
merged 9 commits into from
Sep 3, 2024
Merged

[Experimental] Child Aggregates #614

merged 9 commits into from
Sep 3, 2024

Conversation

DanielBadura
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 13, 2024 •
edited
Loading

Hello 👋

here is the most recent benchmark result: 

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.232ms (±0.00%)   | 932.100μs (±0.00%) | +32.17%   | 35.396mb        | 35.404mb   | -0.02%      |
| benchLoad10000Events ()                | 83.930ms (±0.00%)  | 83.353ms (±0.00%)  | +0.69%    | 35.396mb        | 35.404mb   | -0.02%      |
| benchSave1Event ()                     | 1.852ms (±0.00%)   | 1.584ms (±0.00%)   | +16.94%   | 34.895mb        | 34.895mb   | +0.00%      |
| benchSave10000Events ()                | 249.622ms (±0.00%) | 260.255ms (±0.00%) | -4.09%    | 34.896mb        | 34.896mb   | +0.00%      |
| benchSave10000Aggregates ()            | 13.025s (±0.00%)   | 13.080s (±0.00%)   | -0.42%    | 34.895mb        | 34.895mb   | +0.00%      |
| benchSave10000AggregatesTransaction () | 8.773s (±0.00%)    | 8.891s (±0.00%)    | -1.33%    | 35.396mb        | 35.396mb   | +0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.039ms (±0.00%)   | 1.018ms (±0.00%)   | +2.12%    | 33.765mb        | 33.765mb   | +0.00%      |
| benchLoad10000Events ()                | 52.304ms (±0.00%)  | 49.542ms (±0.00%)  | +5.58%    | 33.765mb        | 33.765mb   | +0.00%      |
| benchSave1Event ()                     | 994.100μs (±0.00%) | 1.082ms (±0.00%)   | -8.08%    | 33.765mb        | 33.765mb   | +0.00%      |
| benchSave10000Events ()                | 218.366ms (±0.00%) | 233.507ms (±0.00%) | -6.48%    | 33.765mb        | 33.768mb   | -0.01%      |
| benchSave10000Aggregates ()            | 9.085s (±0.00%)    | 9.482s (±0.00%)    | -4.20%    | 33.765mb        | 33.765mb   | +0.00%      |
| benchSave10000AggregatesTransaction () | 4.755s (±0.00%)    | 4.758s (±0.00%)    | -0.04%    | 33.765mb        | 33.765mb   | +0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.868ms (±0.00%)   | 5.037ms (±0.00%)   | -3.35%    | 37.071mb        | 37.071mb   | +0.00%      |
| benchSave10000Events () | 339.141ms (±0.00%) | 343.824ms (±0.00%) | -1.36%    | 37.144mb        | 37.147mb   | -0.01%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 50.358ms (±0.00%)  | 52.821ms (±0.00%)  | -4.66%    | 33.765mb        | 33.765mb   | +0.00%      |
| benchLoad10000Events ()                | 957.500μs (±0.00%) | 904.000μs (±0.00%) | +5.92%    | 33.765mb        | 33.765mb   | +0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.047s (±0.00%) | 3.072s (±0.00%) | -0.83%    | 34.164mb        | 34.164mb   | +0.00%      |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 937.100μs (±0.00%) | 962.000μs (±0.00%) | -2.59%    | 34.744mb        | 34.744mb   | +0.00%      |
| benchLoad10000Events ()                | 45.885ms (±0.00%)  | 48.551ms (±0.00%)  | -5.49%    | 34.744mb        | 34.744mb   | +0.00%      |
| benchSave1Event ()                     | 1.144ms (±0.00%)   | 977.800μs (±0.00%) | +16.97%   | 34.744mb        | 34.744mb   | +0.00%      |
| benchSave10000Events ()                | 210.566ms (±0.00%) | 222.192ms (±0.00%) | -5.23%    | 34.744mb        | 34.744mb   | +0.00%      |
| benchSave10000Aggregates ()            | 9.443s (±0.00%)    | 10.192s (±0.00%)   | -7.34%    | 34.744mb        | 34.744mb   | +0.00%      |
| benchSave10000AggregatesTransaction () | 4.719s (±0.00%)    | 4.743s (±0.00%)    | -0.51%    | 34.744mb        | 34.744mb   | +0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura added this to the 3.4.0 milestone Jul 24, 2024
@DavidBadura DavidBadura changed the base branch from 3.3.x to 3.4.x July 24, 2024 14:23
@DavidBadura DavidBadura added the enhancement New feature or request label Aug 13, 2024
@DavidBadura DavidBadura changed the title Scribble for child aggregates [Experimental] Child Aggregates Aug 13, 2024
@DavidBadura DavidBadura self-requested a review August 13, 2024 11:23
@DanielBadura DanielBadura linked an issue Aug 13, 2024 that may be closed by this pull request
Add possibility to define additional child aggregates under the aggregate root #210
Closed
@DanielBadura DanielBadura mentioned this pull request Aug 13, 2024
Closed
@DanielBadura DanielBadura marked this pull request as ready for review August 13, 2024 14:36
@DavidBadura DavidBadura merged commit 70167dc into 3.4.x Sep 3, 2024
38 of 39 checks passed
@DavidBadura DavidBadura deleted the child-aggregates branch September 3, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidBadura DavidBadura DavidBadura approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Add possibility to define additional child aggregates under the aggregate root
2 participants
@DanielBadura @DavidBadura