Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont lock for discoverNewSubscriptions & get subscriptions #653

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Dec 10, 2024

To add new subscriptions (discovering), it is not necessary to lock other subscriptions, as these will not be changed. If discovering new subscriptions is no longer locking, reading the status of the subscriptions is no longer locking either.

@DavidBadura DavidBadura added the bug Something isn't working label Dec 10, 2024
@DavidBadura DavidBadura added this to the 3.5.1 milestone Dec 10, 2024
@DavidBadura DavidBadura force-pushed the dont-lock-for-get-subscriptions branch from b2e315e to b268fcf Compare December 10, 2024 15:25
@DavidBadura DavidBadura changed the title dont lock by discoverNewSubscriptions dont lock for discoverNewSubscriptions & get subscriptions Dec 10, 2024
Copy link

github-actions bot commented Dec 10, 2024

Hello 👋

here is the most recent benchmark result:

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.049s (±0.00%) | 3.079s (±0.00%) | -1.00%    | 34.736mb        | 34.744mb   | -0.02%      |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 72.116ms (±0.00%) | 76.747ms (±0.00%) | -6.03%    | 34.234mb        | 34.234mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 898.600μs (±0.00%) | 888.300μs (±0.00%) | +1.16%    | 34.744mb        | 34.744mb   | 0.00%       |
| benchLoad10000Events ()                | 49.885ms (±0.00%)  | 48.294ms (±0.00%)  | +3.29%    | 34.744mb        | 34.744mb   | 0.00%       |
| benchSave1Event ()                     | 995.000μs (±0.00%) | 1.152ms (±0.00%)   | -13.63%   | 34.744mb        | 34.744mb   | 0.00%       |
| benchSave10000Events ()                | 221.962ms (±0.00%) | 222.563ms (±0.00%) | -0.27%    | 34.744mb        | 34.744mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.222s (±0.00%)    | 8.543s (±0.00%)    | -3.75%    | 34.744mb        | 34.744mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.710s (±0.00%)    | 4.730s (±0.00%)    | -0.41%    | 34.745mb        | 34.745mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 50.074ms (±0.00%)  | 48.240ms (±0.00%)  | +3.80%    | 33.836mb        | 33.836mb   | 0.00%       |
| benchLoad10000Events ()                | 908.300μs (±0.00%) | 935.600μs (±0.00%) | -2.92%    | 33.836mb        | 33.836mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.486ms (±0.00%)   | 4.434ms (±0.00%)   | +1.18%    | 37.072mb        | 37.072mb   | 0.00%       |
| benchSave10000Events () | 349.888ms (±0.00%) | 360.077ms (±0.00%) | -2.83%    | 37.144mb        | 37.144mb   | 0.00%       |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 885.000μs (±0.00%) | 902.400μs (±0.00%) | -1.93%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchLoad10000Events ()                | 85.736ms (±0.00%)  | 82.613ms (±0.00%)  | +3.78%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave1Event ()                     | 1.433ms (±0.00%)   | 1.447ms (±0.00%)   | -0.95%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave10000Events ()                | 255.815ms (±0.00%) | 257.325ms (±0.00%) | -0.59%    | 34.897mb        | 34.897mb   | 0.00%       |
| benchSave10000Aggregates ()            | 12.503s (±0.00%)   | 12.386s (±0.00%)   | +0.95%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 8.779s (±0.00%)    | 8.778s (±0.00%)    | +0.01%    | 35.396mb        | 35.396mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 940.100μs (±0.00%) | 941.200μs (±0.00%) | -0.12%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchLoad10000Events ()                | 48.848ms (±0.00%)  | 51.120ms (±0.00%)  | -4.45%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave1Event ()                     | 1.036ms (±0.00%)   | 1.057ms (±0.00%)   | -2.04%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000Events ()                | 222.994ms (±0.00%) | 222.762ms (±0.00%) | +0.10%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.316s (±0.00%)    | 8.012s (±0.00%)    | +3.80%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.719s (±0.00%)    | 4.717s (±0.00%)    | +0.04%    | 33.765mb        | 33.765mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura merged commit 9217fa2 into 3.5.x Dec 11, 2024
40 checks passed
@DavidBadura DavidBadura deleted the dont-lock-for-get-subscriptions branch December 11, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants