Skip to content

Remove prophecy, change tests to use phpunit native mocking #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2025
Merged

Remove prophecy, change tests to use phpunit native mocking #738

merged 2 commits into from
Jun 27, 2025

Conversation

@DanielBadura
Copy link
Member

@DanielBadura DanielBadura commented May 5, 2025

No description provided.

@DanielBadura DanielBadura mentioned this pull request May 5, 2025
Open
4 tasks
@github-actions
Copy link

github-actions bot commented May 5, 2025 •
edited
Loading

Hello 👋

here is the most recent benchmark result: 

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.520ms (±0.00%)   | 4.392ms (±0.00%)   | +2.92%    | 38.176mb        | 38.186mb   | -0.02%      |
| benchSave10000Events () | 340.277ms (±0.00%) | 354.612ms (±0.00%) | -4.04%    | 38.248mb        | 37.723mb   | +1.39%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.042ms (±0.00%)   | 986.900μs (±0.00%) | +5.53%    | 34.458mb        | 34.458mb   | 0.00%       |
| benchLoad10000Events ()                | 58.172ms (±0.00%)  | 56.714ms (±0.00%)  | +2.57%    | 34.458mb        | 34.458mb   | 0.00%       |
| benchSave1Event ()                     | 1.160ms (±0.00%)   | 1.014ms (±0.00%)   | +14.33%   | 34.458mb        | 34.458mb   | 0.00%       |
| benchSave10000Events ()                | 285.150ms (±0.00%) | 290.685ms (±0.00%) | -1.90%    | 34.458mb        | 34.458mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.558s (±0.00%)    | 10.337s (±0.00%)   | -17.20%   | 34.458mb        | 34.458mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.109s (±0.00%)    | 5.119s (±0.00%)    | -0.19%    | 34.458mb        | 34.458mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.192s (±0.00%) | 3.176s (±0.00%) | +0.49%    | 46.961mb        | 46.961mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 985.800μs (±0.00%) | 986.600μs (±0.00%) | -0.08%    | 34.344mb        | 34.344mb   | 0.00%       |
| benchLoad10000Events ()                | 52.893ms (±0.00%)  | 51.313ms (±0.00%)  | +3.08%    | 34.344mb        | 34.344mb   | 0.00%       |
| benchSave1Event ()                     | 1.168ms (±0.00%)   | 1.145ms (±0.00%)   | +2.09%    | 34.344mb        | 34.344mb   | 0.00%       |
| benchSave10000Events ()                | 217.547ms (±0.00%) | 219.491ms (±0.00%) | -0.89%    | 34.344mb        | 34.344mb   | 0.00%       |
| benchSave10000Aggregates ()            | 9.521s (±0.00%)    | 8.828s (±0.00%)    | +7.85%    | 34.344mb        | 34.344mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.897s (±0.00%)    | 4.891s (±0.00%)    | +0.12%    | 34.344mb        | 34.344mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 77.741ms (±0.00%) | 77.260ms (±0.00%) | +0.62%    | 34.813mb        | 34.813mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 53.107ms (±0.00%)  | 51.538ms (±0.00%)  | +3.04%    | 34.418mb        | 34.418mb   | 0.00%       |
| benchLoad10000Events ()                | 894.400μs (±0.00%) | 934.100μs (±0.00%) | -4.25%    | 34.418mb        | 34.418mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 888.700μs (±0.00%) | 973.300μs (±0.00%) | -8.69%    | 35.548mb        | 35.548mb   | 0.00%       |
| benchLoad10000Events ()                | 95.004ms (±0.00%)  | 95.330ms (±0.00%)  | -0.34%    | 35.548mb        | 35.548mb   | 0.00%       |
| benchSave1Event ()                     | 1.435ms (±0.00%)   | 1.835ms (±0.00%)   | -21.80%   | 35.548mb        | 35.548mb   | 0.00%       |
| benchSave10000Events ()                | 251.864ms (±0.00%) | 265.311ms (±0.00%) | -5.07%    | 35.550mb        | 35.550mb   | 0.00%       |
| benchSave10000Aggregates ()            | 13.456s (±0.00%)   | 12.692s (±0.00%)   | +6.02%    | 35.548mb        | 35.548mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 9.096s (±0.00%)    | 9.144s (±0.00%)    | -0.53%    | 36.050mb        | 36.050mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DanielBadura DanielBadura force-pushed the remove-prophecy branch 3 times, most recently from 449d601 to cfd0daa Compare June 26, 2025 18:49
@DanielBadura DanielBadura marked this pull request as ready for review June 26, 2025 19:32
@DanielBadura DanielBadura requested a review from DavidBadura June 26, 2025 19:32
@DanielBadura DanielBadura self-assigned this Jun 26, 2025
@DanielBadura DanielBadura added the enhancement New feature or request label Jun 26, 2025
@DanielBadura DanielBadura merged commit f607637 into 3.12.x Jun 27, 2025
40 checks passed
@DanielBadura DanielBadura added this to the 3.12.0 milestone Jun 27, 2025
@DanielBadura DanielBadura deleted the remove-prophecy branch June 27, 2025 08:23
@github-actions github-actions bot mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidBadura DavidBadura DavidBadura approved these changes

Assignees

@DanielBadura DanielBadura

Labels

enhancement New feature or request

Projects

None yet

Milestone

3.12.0

Development

Successfully merging this pull request may close these issues.

3 participants

@DanielBadura @DavidBadura