Skip to content

Conversation

@DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Jun 18, 2025

This was never released, so we can remove it directly instead of deprecating it.
Use InstantRetryCommandBus (#751) instead.

@DavidBadura DavidBadura added this to the 3.12.0 milestone Jun 18, 2025
@DavidBadura DavidBadura requested a review from DanielBadura June 18, 2025 07:49
@DavidBadura DavidBadura force-pushed the remove-retry-outdated-aggregate-command-bus branch from c0501e3 to d786ae1 Compare June 18, 2025 07:52
@github-actions
Copy link

github-actions bot commented Jun 18, 2025

Hello 👋

here is the most recent benchmark result:

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 74.047ms (±0.00%) | 73.795ms (±0.00%) | +0.34%    | 34.743mb        | 35.275mb   | -1.51%      |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 53.370ms (±0.00%)  | 52.452ms (±0.00%)  | +1.75%    | 34.348mb        | 34.348mb   | 0.00%       |
| benchLoad10000Events ()                | 908.600μs (±0.00%) | 918.200μs (±0.00%) | -1.05%    | 34.348mb        | 34.348mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.225s (±0.00%) | 3.235s (±0.00%) | -0.33%    | 46.891mb        | 46.891mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 984.700μs (±0.00%) | 964.700μs (±0.00%) | +2.07%    | 34.457mb        | 34.457mb   | 0.00%       |
| benchLoad10000Events ()                | 55.325ms (±0.00%)  | 59.671ms (±0.00%)  | -7.28%    | 34.457mb        | 34.457mb   | 0.00%       |
| benchSave1Event ()                     | 1.039ms (±0.00%)   | 1.015ms (±0.00%)   | +2.27%    | 34.457mb        | 34.457mb   | 0.00%       |
| benchSave10000Events ()                | 286.291ms (±0.00%) | 296.536ms (±0.00%) | -3.45%    | 34.457mb        | 34.457mb   | 0.00%       |
| benchSave10000Aggregates ()            | 7.835s (±0.00%)    | 7.764s (±0.00%)    | +0.91%    | 34.458mb        | 34.458mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.122s (±0.00%)    | 5.108s (±0.00%)    | +0.27%    | 34.458mb        | 34.458mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.361ms (±0.00%)   | 4.374ms (±0.00%)   | -0.30%    | 37.650mb        | 37.650mb   | 0.00%       |
| benchSave10000Events () | 333.182ms (±0.00%) | 333.526ms (±0.00%) | -0.10%    | 37.653mb        | 37.653mb   | +0.00%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 951.000μs (±0.00%) | 972.200μs (±0.00%) | -2.18%    | 34.343mb        | 34.343mb   | 0.00%       |
| benchLoad10000Events ()                | 50.761ms (±0.00%)  | 52.702ms (±0.00%)  | -3.68%    | 34.344mb        | 34.344mb   | 0.00%       |
| benchSave1Event ()                     | 1.010ms (±0.00%)   | 1.009ms (±0.00%)   | +0.12%    | 34.343mb        | 34.343mb   | 0.00%       |
| benchSave10000Events ()                | 212.796ms (±0.00%) | 215.850ms (±0.00%) | -1.41%    | 34.344mb        | 34.344mb   | 0.00%       |
| benchSave10000Aggregates ()            | 7.605s (±0.00%)    | 7.517s (±0.00%)    | +1.17%    | 34.344mb        | 34.344mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.922s (±0.00%)    | 4.961s (±0.00%)    | -0.79%    | 34.344mb        | 34.344mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 971.600μs (±0.00%) | 963.900μs (±0.00%) | +0.80%    | 35.478mb        | 35.478mb   | 0.00%       |
| benchLoad10000Events ()                | 94.364ms (±0.00%)  | 94.748ms (±0.00%)  | -0.41%    | 35.478mb        | 35.478mb   | 0.00%       |
| benchSave1Event ()                     | 1.448ms (±0.00%)   | 1.499ms (±0.00%)   | -3.43%    | 35.478mb        | 35.478mb   | 0.00%       |
| benchSave10000Events ()                | 255.061ms (±0.00%) | 253.305ms (±0.00%) | +0.69%    | 35.479mb        | 35.479mb   | 0.00%       |
| benchSave10000Aggregates ()            | 11.891s (±0.00%)   | 11.905s (±0.00%)   | -0.12%    | 35.478mb        | 35.478mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 9.105s (±0.00%)    | 9.138s (±0.00%)    | -0.36%    | 35.980mb        | 35.980mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura merged commit fb798ff into 3.12.x Jun 18, 2025
39 of 40 checks passed
@DavidBadura DavidBadura deleted the remove-retry-outdated-aggregate-command-bus branch June 18, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants