Skip to content

add same database check #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 3, 2025
Merged

add same database check #773

merged 3 commits into from
Sep 3, 2025

Conversation

@DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Sep 3, 2025 •
edited
Loading

fix #772

The solution was inspired by Symfony: symfony/symfony#48059

@DavidBadura DavidBadura added this to the 3.12.0 milestone Sep 3, 2025
@DavidBadura DavidBadura added the bug Something isn't working label Sep 3, 2025
@github-actions
Copy link

github-actions bot commented Sep 3, 2025 •
edited
Loading

Hello 👋

here is the most recent benchmark result: 

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 5.098ms (±0.00%)   | 4.894ms (±0.00%)   | +4.16%    | 34.893mb        | 35.428mb   | -1.51%      |
| benchSave10000Events () | 326.627ms (±0.00%) | 336.394ms (±0.00%) | -2.90%    | 34.960mb        | 34.960mb   | -0.00%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.099ms (±0.00%)   | 1.082ms (±0.00%)   | +1.57%    | 34.385mb        | 34.385mb   | +0.00%      |
| benchLoad10000Events ()                | 50.767ms (±0.00%)  | 50.176ms (±0.00%)  | +1.18%    | 34.385mb        | 34.385mb   | +0.00%      |
| benchSave1Event ()                     | 1.224ms (±0.00%)   | 1.446ms (±0.00%)   | -15.30%   | 34.385mb        | 34.385mb   | +0.00%      |
| benchSave10000Events ()                | 211.117ms (±0.00%) | 214.097ms (±0.00%) | -1.39%    | 34.385mb        | 34.457mb   | -0.21%      |
| benchSave10000Aggregates ()            | 8.112s (±0.00%)    | 8.028s (±0.00%)    | +1.04%    | 34.385mb        | 34.385mb   | +0.00%      |
| benchSave10000AggregatesTransaction () | 4.916s (±0.00%)    | 4.910s (±0.00%)    | +0.12%    | 34.385mb        | 34.385mb   | +0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.104ms (±0.00%)   | 1.118ms (±0.00%)   | -1.32%    | 35.580mb        | 35.580mb   | +0.00%      |
| benchLoad10000Events ()                | 91.393ms (±0.00%)  | 94.749ms (±0.00%)  | -3.54%    | 35.580mb        | 35.580mb   | +0.00%      |
| benchSave1Event ()                     | 1.733ms (±0.00%)   | 1.584ms (±0.00%)   | +9.37%    | 35.580mb        | 35.580mb   | +0.00%      |
| benchSave10000Events ()                | 248.584ms (±0.00%) | 245.864ms (±0.00%) | +1.11%    | 35.582mb        | 35.582mb   | +0.00%      |
| benchSave10000Aggregates ()            | 12.376s (±0.00%)   | 12.354s (±0.00%)   | +0.18%    | 35.580mb        | 35.580mb   | +0.00%      |
| benchSave10000AggregatesTransaction () | 9.094s (±0.00%)    | 9.134s (±0.00%)    | -0.44%    | 36.039mb        | 36.039mb   | +0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.184s (±0.00%) | 3.170s (±0.00%) | +0.44%    | 47.078mb        | 47.078mb   | +0.00%      |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.096ms (±0.00%)   | 1.089ms (±0.00%)   | +0.62%    | 34.568mb        | 34.568mb   | +0.00%      |
| benchLoad10000Events ()                | 57.505ms (±0.00%)  | 59.825ms (±0.00%)  | -3.88%    | 34.568mb        | 34.568mb   | +0.00%      |
| benchSave1Event ()                     | 1.300ms (±0.00%)   | 1.278ms (±0.00%)   | +1.68%    | 34.568mb        | 34.568mb   | +0.00%      |
| benchSave10000Events ()                | 296.466ms (±0.00%) | 280.043ms (±0.00%) | +5.86%    | 34.568mb        | 34.568mb   | +0.00%      |
| benchSave10000Aggregates ()            | 8.484s (±0.00%)    | 8.433s (±0.00%)    | +0.61%    | 34.568mb        | 34.568mb   | +0.00%      |
| benchSave10000AggregatesTransaction () | 5.110s (±0.00%)    | 5.066s (±0.00%)    | +0.88%    | 34.569mb        | 34.568mb   | +0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                   | memory                                     |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 50.400ms (±0.00%) | 51.029ms (±0.00%) | -1.23%    | 34.390mb        | 34.390mb   | +0.00%      |
| benchLoad10000Events ()                | 1.132ms (±0.00%)  | 1.307ms (±0.00%)  | -13.36%   | 34.390mb        | 34.389mb   | +0.00%      |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 75.597ms (±0.00%) | 77.243ms (±0.00%) | -2.13%    | 34.850mb        | 34.849mb   | +0.00%      |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura mentioned this pull request Sep 3, 2025
Closed
@DavidBadura DavidBadura merged commit 6f641db into 3.12.x Sep 3, 2025
40 checks passed
@DavidBadura DavidBadura deleted the same-database branch September 3, 2025 15:09
@github-actions github-actions bot mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanielBadura DanielBadura DanielBadura approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

3.12.0

Development

Successfully merging this pull request may close these issues.

Using merge_orm_schema with two connections creates incomplete schema

3 participants

@DavidBadura @DanielBadura