Skip to content

Middleware based hydrator #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2.0.x
Choose a base branch
from
Open

Middleware based hydrator #117

wants to merge 1 commit into from

Conversation

@DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Oct 29, 2025

No description provided.

@DavidBadura DavidBadura changed the base branch from 1.12.x to 2.0.x October 29, 2025 13:51
@github-actions
Copy link

github-actions bot commented Oct 29, 2025 •
edited
Loading

Hello 👋

here is the most recent benchmark result: 

HydratorWithCryptographyBench
=============================

+-------------------------------+--------------------+--------------------+-----------------+------------+
|                               | time (kde mode)                         | memory                       |
+-------------------------------+--------------------+--------------------+-----------------+------------+
| subject                       | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------------+--------------------+--------------------+-----------------+------------+
| benchHydrate1Object ()        | 112.000μs (±0.00%) | 114.000μs (±0.00%) | 3.322mb         | 3.334mb    |
| benchExtract1Object ()        | 7.400μs (±0.00%)   | 10.600μs (±0.00%)  | 3.322mb         | 3.334mb    |
| benchHydrate1000Objects ()    | 3.613ms (±0.00%)   | 3.891ms (±0.00%)   | 3.504mb         | 3.479mb    |
| benchExtract1000Objects ()    | 5.228ms (±0.00%)   | 5.554ms (±0.00%)   | 3.478mb         | 3.402mb    |
| benchHydrate1000000Objects () | 1.973s (±0.00%)    | 2.196s (±0.00%)    | 3.504mb         | 2.993mb    |
| benchExtract1000000Objects () | 3.631s (±0.00%)    | 4.010s (±0.00%)    | 3.001mb         | 2.916mb    |
+-------------------------------+--------------------+--------------------+-----------------+------------+

HydratorBench
=============

+-------------------------------+------------------+-------------------+-----------------+------------+
|                               | time (kde mode)                      | memory                       |
+-------------------------------+------------------+-------------------+-----------------+------------+
| subject                       | Tag: <current>   | Tag: base         | Tag: <current>  | Tag: base  |
+-------------------------------+------------------+-------------------+-----------------+------------+
| benchHydrate1Object ()        | 3.000μs (±0.00%) | 73.600μs (±0.00%) | 2.829mb         | 2.829mb    |
| benchExtract1Object ()        | 3.800μs (±0.00%) | 3.200μs (±0.00%)  | 2.829mb         | 2.829mb    |
| benchHydrate1000Objects ()    | 2.551ms (±0.00%) | 1.989ms (±0.00%)  | 2.860mb         | 2.829mb    |
| benchExtract1000Objects ()    | 2.455ms (±0.00%) | 1.855ms (±0.00%)  | 2.854mb         | 2.829mb    |
| benchHydrate1000000Objects () | 1.395s (±0.00%)  | 1.060s (±0.00%)   | 2.860mb         | 2.829mb    |
| benchExtract1000000Objects () | 1.626s (±0.00%)  | 1.216s (±0.00%)   | 2.854mb         | 2.829mb    |
+-------------------------------+------------------+-------------------+-----------------+------------+

HydratorWithLazyBench
=====================

+------------------------------------------+--------------------+--------------------+-----------------+------------+
|                                          | time (kde mode)                         | memory                       |
+------------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                  | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+------------------------------------------+--------------------+--------------------+-----------------+------------+
| benchHydrate1Object ()                   | 0.800μs (±0.00%)   | 0.800μs (±0.00%)   | 2.829mb         | 2.829mb    |
| benchHydrate1ObjectTriggerInit ()        | 3.600μs (±0.00%)   | 123.400μs (±0.00%) | 2.829mb         | 2.834mb    |
| benchHydrate1000Objects ()               | 399.667μs (±0.00%) | 403.000μs (±0.00%) | 2.829mb         | 2.829mb    |
| benchHydrate1000ObjectsTriggerInit ()    | 3.091ms (±0.00%)   | 2.810ms (±0.00%)   | 2.835mb         | 2.834mb    |
| benchHydrate1000000Objects ()            | 266.258ms (±0.00%) | 263.245ms (±0.00%) | 2.829mb         | 2.829mb    |
| benchHydrate1000000ObjectsTriggerInit () | 2.076s (±0.00%)    | 1.934s (±0.00%)    | 2.835mb         | 2.834mb    |
+------------------------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DanielBadura DanielBadura mentioned this pull request Nov 10, 2025
Open
@DavidBadura DavidBadura force-pushed the middleware-hydrator branch 9 times, most recently from 3f32c8f to 9e54004 Compare November 19, 2025 15:48
@DavidBadura DavidBadura changed the title Middleware hydrator Middleware based hydrator Nov 19, 2025
@DavidBadura DavidBadura force-pushed the middleware-hydrator branch 2 times, most recently from ade3a43 to 6e02329 Compare November 19, 2025 15:58
@DavidBadura DavidBadura added this to the 2.0.0 milestone Nov 19, 2025
@DavidBadura DavidBadura added BC break enhancement New feature or request labels Nov 19, 2025
@DavidBadura DavidBadura force-pushed the middleware-hydrator branch 2 times, most recently from d77e11a to 4557026 Compare November 20, 2025 12:48
@DavidBadura DavidBadura marked this pull request as ready for review November 21, 2025 12:45
@DavidBadura DavidBadura mentioned this pull request Nov 21, 2025
Draft
DanielBadura
DanielBadura requested changes Nov 22, 2025
View reviewed changes
Copy link
Member

@DanielBadura DanielBadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a Unit Test for CryptographyMiddleware and more importantly TransformMiddleware? Otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanielBadura DanielBadura DanielBadura requested changes

Assignees

No one assigned

Labels

BC break enhancement New feature or request

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@DavidBadura @DanielBadura