forked from apache/airflow
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#16692 show cron schedule description in UI #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…16692-show-cron-schedule-description-in-ui
…16692-show-cron-schedule-description-in-ui
Co-authored-by: Ryan Hamilton <ryan@ryanahamilton.com>
…16692-show-cron-schedule-description-in-ui-v2
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
…16692-show-cron-schedule-description-in-ui
…16692-show-cron-schedule-description-in-ui
…16692-show-cron-schedule-description-in-ui
…16692-show-cron-schedule-description-in-ui
…16692-show-cron-schedule-description-in-ui
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
…ttps://github.com/pateash/airflow into apache#16692-show-cron-schedule-description-in-ui
…n-schedule-description-in-ui
Signed-off-by: Ashish Patel <ashishpatel0720@gmail.com>
pateash
added a commit
that referenced
this pull request
Dec 12, 2021
* Create ap_codeql-analysis.yml * 16692 - deleted file * 16692 - changes done * 16692 - test added * 16692 - pre-commits fixed * 16692 - pre-commits fixed * 16692 - pre-commits fixed * 16692 - Runs removed from description * Update airflow/www/templates/airflow/dags.html Co-authored-by: Ryan Hamilton <ryan@ryanahamilton.com> * 16692 - pre-commits fixed * 16692 - using timetable for showing description * 16692 - pre-commits fixed * Update airflow/timetables/base.py Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> * 16692 - fixed types * 16692 - used Base class for storing common properties * 16692 - using cached_property for description * 16692 - using cached_property for description * 16692 - merge fix * 16692 - removed dagbase * 16692 - removed unnecessary changes * 16692 - test name fixed * 16692 - timetable_description column added to dag table. * 16692 - None timetable description updated * 16692 - tests added * 16692 - review comments. * 16692 - precommit fixes * 16692 - precommit fixes * 16692 - fixed test checks * 16692 - ignoring description computation for 6th param in Cron expression * 16692 - pre-commit fixed * Update airflow/timetables/base.py Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> * 16692 - documentation added for timetable description * 16692 - resolving PR comments * 16692 - precommit fixes * 16692 - documentation fix * 16692 - using empty string as a default description * 16692 - test fixed * [apache#16692] - migration file updated Signed-off-by: Ashish Patel <ashishpatel0720@gmail.com> Co-authored-by: Ryan Hamilton <ryan@ryanahamilton.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.