Add lock as a function

patil-vipul · May 16, 2024 · 051c6a4 · 051c6a4
1 parent 471c8b2
commit 051c6a4
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 8 deletions.
diff --git a/packages/block-editor/src/components/rich-text/index.js b/packages/block-editor/src/components/rich-text/index.js
@@ -186,7 +186,7 @@ export function RichTextWrapper(
 					);
 					if (
 						! blockBindingsSource ||
-						blockBindingsSource.lockAttributesEditing
+						blockBindingsSource.lockAttributesEditing()
 					) {
 						_disableBoundBlocks = true;
 						break;

diff --git a/packages/block-library/src/button/edit.js b/packages/block-library/src/button/edit.js
@@ -247,7 +247,7 @@ function ButtonEdit( props ) {
 				lockUrlControls:
 					!! metadata?.bindings?.url &&
 					( ! blockBindingsSource ||
-						blockBindingsSource?.lockAttributesEditing ),
+						blockBindingsSource?.lockAttributesEditing() ),
 			};
 		},
 		[ isSelected ]

diff --git a/packages/block-library/src/image/edit.js b/packages/block-library/src/image/edit.js
@@ -318,7 +318,7 @@ export function ImageEdit( {
 				lockUrlControls:
 					!! metadata?.bindings?.url &&
 					( ! blockBindingsSource ||
-						blockBindingsSource?.lockAttributesEditing ),
+						blockBindingsSource?.lockAttributesEditing() ),
 				lockUrlControlsMessage: blockBindingsSource?.label
 					? sprintf(
 							/* translators: %s: Label of the bindings source. */

diff --git a/packages/block-library/src/image/image.js b/packages/block-library/src/image/image.js
@@ -463,7 +463,7 @@ export default function Image( {
 				lockUrlControls:
 					!! urlBinding &&
 					( ! urlBindingSource ||
-						urlBindingSource?.lockAttributesEditing ),
+						urlBindingSource?.lockAttributesEditing() ),
 				lockHrefControls:
 					// Disable editing the link of the URL if the image is inside a pattern instance.
 					// This is a temporary solution until we support overriding the link on the frontend.
@@ -475,7 +475,7 @@ export default function Image( {
 				lockAltControls:
 					!! altBinding &&
 					( ! altBindingSource ||
-						altBindingSource?.lockAttributesEditing ),
+						altBindingSource?.lockAttributesEditing() ),
 				lockAltControlsMessage: altBindingSource?.label
 					? sprintf(
 							/* translators: %s: Label of the bindings source. */
@@ -486,7 +486,7 @@ export default function Image( {
 				lockTitleControls:
 					!! titleBinding &&
 					( ! titleBindingSource ||
-						titleBindingSource?.lockAttributesEditing ),
+						titleBindingSource?.lockAttributesEditing() ),
 				lockTitleControlsMessage: titleBindingSource?.label
 					? sprintf(
 							/* translators: %s: Label of the bindings source. */

diff --git a/packages/blocks/src/store/reducer.js b/packages/blocks/src/store/reducer.js
@@ -381,7 +381,10 @@ export function blockBindingsSources( state = {}, action ) {
 				setValue: action.setValue,
 				setValues: action.setValues,
 				getPlaceholder: action.getPlaceholder,
-				lockAttributesEditing: action.lockAttributesEditing ?? true,
+				lockAttributesEditing: () =>
+					action.lockAttributesEditing
+						? action.lockAttributesEditing()
+						: true,
 			},
 		};
 	}

diff --git a/packages/editor/src/bindings/pattern-overrides.js b/packages/editor/src/bindings/pattern-overrides.js
@@ -89,5 +89,7 @@ export default {
 				},
 			} );
 	},
-	lockAttributesEditing: false,
+	lockAttributesEditing() {
+		return false;
+	},
 };