Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restructure amount #554

Closed
5 tasks done
sbello opened this issue Feb 19, 2024 · 2 comments · Fixed by #560
Closed
5 tasks done

restructure amount #554

sbello opened this issue Feb 19, 2024 · 2 comments · Fixed by #560
Assignees
@rays22
Labels
upheno uPheno related tickets

Comments

@sbello
Copy link
Contributor

sbello commented Feb 19, 2024 •
edited by rays22
Loading

From the UPheno call on Jan, 26 2024
Request changes to PATO

  • Create a quantitative branch
  • Move amount under this
  • Make concentration a child of amount
  • Remove reciprocal relation to ‘has number of’
  • Make has number of a child of amount

See minutes https://docs.google.com/document/d/1WrQanAMuccS-oaoAIb9yWQAd4Rvy3R3mU01v9wHbriM/edit?usp=sharing
@sbello sbello added the upheno uPheno related tickets label Feb 19, 2024
@sbello
Copy link
Contributor Author

sbello commented Apr 19, 2024

Would also be good to define qualitative

@rays22 rays22 mentioned this issue Jun 13, 2024
Open
@rays22
Copy link
Collaborator

rays22 commented Jun 13, 2024 •
edited
Loading

  • quantitative
    Proposed textual definition: A quality relating to an amount or number that can be measured or counted.

@rays22 rays22 mentioned this issue Jun 13, 2024
Merged
rays22 added a commit that referenced this issue Jun 13, 2024
@rays22
Improve the textual definition of quantitative
ac902a9 
If applied, this commit will fix #554.
@rays22 rays22 closed this as completed in 15889b4 Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rays22 rays22

Labels
upheno uPheno related tickets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restructure amount pato-ontology/pato
2 participants
@sbello @rays22