Merge pull request #47 from whydoubt/fix_scaling

Improve check for whether canvas is visible
patriciogonzalezvivo · Oct 29, 2022 · 694185d · 694185d
2 parents 445df57 + 736a365
commit 694185d
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 7 deletions.
diff --git a/dist/GlslCanvas.es.js b/dist/GlslCanvas.es.js
@@ -483,7 +483,8 @@ function parseUniforms(uniforms) {
 }
 
 function isCanvasVisible(canvas) {
-    return canvas.getBoundingClientRect().top + canvas.height > 0 && canvas.getBoundingClientRect().top < (window.innerHeight || document.documentElement.clientHeight);
+    var bound = canvas.getBoundingClientRect();
+    return bound.top + bound.height > 0 && bound.top < (window.innerHeight || document.documentElement.clientHeight);
 }
 
 function isPowerOf2(value) {

diff --git a/dist/GlslCanvas.js b/dist/GlslCanvas.js
@@ -888,7 +888,8 @@ function parseUniforms(uniforms) {
 }
 
 function isCanvasVisible(canvas) {
-    return canvas.getBoundingClientRect().top + canvas.height > 0 && canvas.getBoundingClientRect().top < (window.innerHeight || document.documentElement.clientHeight);
+    var bound = canvas.getBoundingClientRect();
+    return bound.top + bound.height > 0 && bound.top < (window.innerHeight || document.documentElement.clientHeight);
 }
 
 function isPowerOf2(value) {

diff --git a/dist/GlslCanvas.min.js b/dist/GlslCanvas.min.js
diff --git a/lib/GlslCanvas.js b/lib/GlslCanvas.js
@@ -884,7 +884,8 @@ function parseUniforms(uniforms) {
 }
 
 function isCanvasVisible(canvas) {
-    return canvas.getBoundingClientRect().top + canvas.height > 0 && canvas.getBoundingClientRect().top < (window.innerHeight || document.documentElement.clientHeight);
+    var bound = canvas.getBoundingClientRect();
+    return bound.top + bound.height > 0 && bound.top < (window.innerHeight || document.documentElement.clientHeight);
 }
 
 function isPowerOf2(value) {

diff --git a/src/tools/common.js b/src/tools/common.js
@@ -1,6 +1,7 @@
 export function isCanvasVisible(canvas) {
-    return	((canvas.getBoundingClientRect().top + canvas.height) > 0) &&
-        (canvas.getBoundingClientRect().top < (window.innerHeight || document.documentElement.clientHeight));
+    let bound = canvas.getBoundingClientRect();
+    return	((bound.top + bound.height) > 0) &&
+        (bound.top < (window.innerHeight || document.documentElement.clientHeight));
 }
 
 export function isPowerOf2(value) {