Add dtypes to the rest of eqx.nn #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
On SpectralNorm, I think the appropriate thing to do is probably to use weight.dtype instead.
By the way, I think BatchNorm could also do with updating: it has a dtype argument but so far only uses these for the moving statistics, but not its learnt parameters. We should probably change that. Would you be able to do that as part of this PR?
Other than that, thank you for doing this! This is all great to see. :D
|
Yup, done. |
|
Neat! LGTM, and thank you for the contribution. We'll have this appear in the next version of Equinox. |
Merged
patrick-kidger
pushed a commit
that referenced
this pull request
Apr 14, 2024
* added dtypes * fixed norms and added info to _spectral_norm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically the same as #680 but for the rest of the API.
Double check
SpectralNorm- I'm not 100% confident in that one.