Fixes for compatibility with JAX version 0.4.28. #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- callback inputs are now `Array`s rather than `array`s. - `emit_python_callback` now uses a keyword argument for what was once a positional argument. Other nice-to-haves whilst I'm here: - Removed `filter_jit` passing function default arguments across the JIT boundary. In particular this is incompatible with `filter_jit(filter_vmap(eqx.nn.MLP(...)))`, as then it tries to pass the `MLP.__call__(..., *, key=...)` default argument through, but `filter_vmap` does not allow keyword arguments. - Added some `stacklevel`s to some warnings.
patrick-kidger
force-pushed
the
0.4.28-fixes
branch
from
840d912 to
2fa8f3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrays rather thanarrays.emit_python_callbacknow uses a keyword argument for what was once a positional argument.Other nice-to-haves whilst I'm here:
filter_jitpassing function default arguments across the JIT boundary. In particular this is incompatible withfilter_jit(filter_vmap(eqx.nn.MLP(...))), as then it tries to pass theMLP.__call__(..., *, key=...)default argument through, butfilter_vmapdoes not allow keyword arguments.stacklevels to some warnings.