Removed _IdDict #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of _IdDict was causing issues with symbol lookups, as we can obtain strings in more than one way. (Which I knew when I originally wrote this, but for some reason thought we avoided.) There was a good reason for looking things up by identity, namely that it makes most sense to look up each AbstractNode by identity. (As they're not otherwise hashable in any meaningful way.) So we've switched to doing that just for AbstractNode instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of _IdDict was causing issues with symbol lookups, as we can
obtain strings in more than one way. (Which I knew when I originally
wrote this, but for some reason thought we avoided.)
There was a good reason for looking things up by identity, namely that
it makes most sense to look up each AbstractNode by identity. (As
they're not otherwise hashable in any meaningful way.) So we've switched
to doing that just for AbstractNode instead.