Open
Conversation
This allows to isolate them from each other so that an exception in a nested group does not affect coroutines running outside.
Owner
patrick-kidger
left a comment
patrick-kidger
left a comment
There was a problem hiding this comment.
Nit aside LGTM!
Do you want to try this in your downstream use-case + confirm that it works there, before we merge it here? Then we can be sure that this isn't missing some detail.
Actually also, I think I've thought of an even neater API:
try:
return (yield from _nest(...)), True
except BaseException as e:
return e, Falseand then the consuming code can do more complicated logic on the exception. Would that be preferable do you think?
| - the first element is either the result of `fn(*args)` or `cleanup(exception)`. | ||
| - whether `fn(*args)` succeeded or failed. | ||
| """ | ||
| if args: |
Owner
There was a problem hiding this comment.
Nit, if len(args) > 0 in the spirit of no-implicit-bool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that an exception in an isolated group of coroutines does not propagate to "outer" coroutines.
This is a follow-up of #20 against the
devbranch.