Skip to content

Commit

Permalink
ci(npm): remove node v16 testing
Browse files Browse the repository at this point in the history
  • Loading branch information
patrickcate committed Sep 2, 2023
1 parent 16bac1b commit c183da1
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
cache: 'npm'

- name: Install dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
release:
if: "!contains(github.event.head_commit.message, 'skip release')"
if: contains(github.event.head_commit.message, 'skip release') == false
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand All @@ -20,7 +20,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18

- name: Install dependencies
run: npm ci
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
jobs:
# This job lints all files with ESLint.
lint:
if: "!contains(github.event.head_commit.message, 'skip ci')"
if: contains(github.event.head_commit.message, 'skip ci') == false
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand All @@ -28,7 +28,7 @@ jobs:

# This job runs all Cypress tests.
cypress-test:
if: "!contains(github.event.head_commit.message, 'skip ci')"
if: contains(github.event.head_commit.message, 'skip ci') == false
runs-on: ${{ matrix.os }}
timeout-minutes: 45
strategy:
Expand All @@ -40,18 +40,18 @@ jobs:
# - macos-latest
# - windows-latest
node:
- 14
- 16
- 18
- 20

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Use Node.js ${{ matrix.node-version }}
- name: Use Node.js ${{ matrix.node }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
node-version: ${{ matrix.node }}
cache: 'npm'

- name: E2E tests on Node v${{ matrix.node }}
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
18

0 comments on commit c183da1

Please sign in to comment.