Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape HTML entities #5

Merged
merged 4 commits into from
Nov 29, 2022
Merged

Escape HTML entities #5

merged 4 commits into from
Nov 29, 2022

Conversation

cuihtlauac
Copy link

When generating a make sure HTML entities are character
encoded in order to avoid being interpreted by the HTML engine.

Character encoding code copied from GitHub repo ocaml/omd, file
src/html.ml

When generating a <span> make sure HTML entities are character
encoded in order to avoid being interpreted by the HTML engine.

Character encoding code copied from GitHub repo ocaml/omd, file
src/html.ml
@cuihtlauac
Copy link
Author

This should allow to fix issue 496 in ocaml.org

Cuihtlauac ALVARADO added 2 commits November 24, 2022 16:36
@patricoferris
Copy link
Owner

Thanks!

You need to add a test_md_html.expected file, then run dune runtest and dune promote the contents to that file for the new test you have added to test this feature :))

@patricoferris
Copy link
Owner

Great, this looks good. Have you tested this in ocaml.org? Do you need a quick release (anything else you want upstream before cutting another one)?

@cuihtlauac
Copy link
Author

I haven't tested yet in ocaml.org and haven't noticed anything else at moment other md issues look omd-ish. You can release when convenient.

@patricoferris
Copy link
Owner

Could you test it in Ocaml.org to make sure it works? (no rush!)

@cuihtlauac
Copy link
Author

cuihtlauac commented Nov 25, 2022

Newbie question. Is this the right command in order to bring hilite 0.1.1 in my ocaml.org switch?

opam pin add hilite https://github.com/patricoferris/hilite.git#v0.1.1

Edited: I was missing the 'v' in the tag name

@patricoferris
Copy link
Owner

Depending on which opam-repository you are using, but hopefully the default has updated so you can do:

opam update
opam install -y hilite.0.1.1

If you want to pin it I don't know if #0.1.1 will work, failing that the commit hash is 473fb61f489702f9c5caed0b69f0073c29417564z so

opam pin git+https://github.com/patricoferris/hilite#473fb61f489702f9c5caed0b69f0073c29417564

@cuihtlauac
Copy link
Author

cuihtlauac commented Nov 25, 2022

Thanks, pinning the hash helped. Except it's my patch which I need to test :-)

opam pin git+https://github.com/cuihtlauac/hilite#38957e008a86362a08ab39001f422b31f7fc4a25

Seems to work (from docs/functional-programming)
Screenshot_2022-11-25_13-25-49

@patricoferris patricoferris merged commit f9345d8 into patricoferris:main Nov 29, 2022
@patricoferris
Copy link
Owner

Awesome, thanks!

patricoferris added a commit to patricoferris/opam-repository that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants