Skip to content

Commit

Permalink
Fix the Python binding to ScaledOrthoProjectionParameters
Browse files Browse the repository at this point in the history
  • Loading branch information
PeterMinin authored and patrikhuber committed May 20, 2018
1 parent 3ad3efc commit 5863f3b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions python/generate-python-bindings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@ PYBIND11_MODULE(eos, eos_module)
.def_property_readonly("R",
[](const fitting::ScaledOrthoProjectionParameters& p) {
Eigen::Matrix3f R; // we could probably use Eigen::Map
for (int col = 0; col < 4; ++col)
for (int row = 0; row < 4; ++row)
for (int col = 0; col < 3; ++col)
for (int row = 0; row < 3; ++row)
R(row, col) = p.R[col][row];
return R;
}, "Rotation matrix") // we can easily make this writable if ever required, just need to add a lambda function with the Eigen to glm matrix conversion.
Expand Down

0 comments on commit 5863f3b

Please sign in to comment.