fixing some graphql caching issues

patsissons · Mar 25, 2023 · df57b82 · df57b82
1 parent 2a31447
commit df57b82
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 2 deletions.
diff --git a/src/lib/client/graphql/Movie.graphql b/src/lib/client/graphql/Movie.graphql
@@ -13,6 +13,7 @@ query Movie($id: Int!) {
       id
       response
       numericalRatings {
+        id
         metascore
         imdbRating
         imdbVotes

diff --git a/src/lib/client/graphql/OMDBMovie.graphql b/src/lib/client/graphql/OMDBMovie.graphql
@@ -3,6 +3,7 @@ query OMDBMovie($imdbId: String!) {
     id
     response
     numericalRatings {
+      id
       metascore
       imdbRating
       imdbVotes

diff --git a/src/lib/server/graphql/resolvers/query/movie.ts b/src/lib/server/graphql/resolvers/query/movie.ts
@@ -19,6 +19,7 @@ export const movie = (async (_source, { id }, { fetch }) => {
   try {
     const {
       credits: { cast },
+      externalIds,
       ...payload
     } = await fetchTMDBJson<MoviePayload>(
       fetch,
@@ -30,6 +31,10 @@ export const movie = (async (_source, { id }, { fetch }) => {
 
     return {
       ...payload,
+      externalIds: {
+        id,
+        ...externalIds,
+      },
       cast,
     }
   } catch (error) {

diff --git a/src/lib/server/graphql/resolvers/types/OMDBMovie.ts b/src/lib/server/graphql/resolvers/types/OMDBMovie.ts
@@ -3,8 +3,9 @@ import type { Maybe, OmdbMovie } from '$lib/types/graphql.generated'
 import type { IObjectTypeResolver } from '@graphql-tools/utils'
 
 export const OMDBMovie: IObjectTypeResolver<OmdbMovie, Context, unknown> = {
-  numericalRatings: ({ metascore, imdbRating, imdbVotes, ratings }) => {
+  numericalRatings: ({ id, metascore, imdbRating, imdbVotes, ratings }) => {
     return {
+      id,
       metascore: toNumber(metascore),
       imdbRating: toNumber(imdbRating),
       imdbVotes: toNumber(imdbVotes, (value) => value.replaceAll(',', '')),

diff --git a/src/lib/server/graphql/schema.graphql b/src/lib/server/graphql/schema.graphql
@@ -68,7 +68,7 @@ type MovieCastCredit {
 }
 
 type ExternalMovieIds {
-  id: Int
+  id: Int!
   imdbId: String
   facebookId: String
   instagramId: String
@@ -77,6 +77,7 @@ type ExternalMovieIds {
 }
 
 type OMDBNumericalRatings {
+  id: ID!
   metascore: Int
   imdbRating: Float
   imdbVotes: Int