We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I've recognized that there's a new option related to the logo to provide the ratio as a string, compare to https://github.com/pattern-lab/patternlab-node/blob/dev/packages/uikit-workshop/src/scripts/lit-components/pl-logo/pl-logo.js - but it seems that the ratio isn't being used/set in that component.
I'd like to suggest to change the "ratio" property to both "width" and "height" properties with their equivalent HTML attributes being used, as the browser determines the aspectratio itself nowadays (as suggested by Jen Simmons, see e.g. https://css-tricks.com/what-if-we-got-aspect-ratio-sized-images-by-doing-almost-nothing/).
I'll open a PR for this.
The text was updated successfully, but these errors were encountered:
Merge pull request #1112 from mfranzke/feature-uikit-ratio-width-height
6a5f60f
feature: UIKit - logo: replaced ratio property #1111
feature: UIKit - logo: replaced ratio property pattern-lab#1111
f631bfd
Merge pull request pattern-lab#1112 from mfranzke/feature-uikit-ratio…
f271af2
…-width-height feature: UIKit - logo: replaced ratio property pattern-lab#1111
Successfully merging a pull request may close this issue.
I've recognized that there's a new option related to the logo to provide the ratio as a string, compare to https://github.com/pattern-lab/patternlab-node/blob/dev/packages/uikit-workshop/src/scripts/lit-components/pl-logo/pl-logo.js - but it seems that the ratio isn't being used/set in that component.
I'd like to suggest to change the "ratio" property to both "width" and "height" properties with their equivalent HTML attributes being used, as the browser determines the aspectratio itself nowadays (as suggested by Jen Simmons, see e.g. https://css-tricks.com/what-if-we-got-aspect-ratio-sized-images-by-doing-almost-nothing/).
I'll open a PR for this.
The text was updated successfully, but these errors were encountered: