Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Docs Site: Can't Close Nav By Tapping Outside on Mobile #1169

Closed
sghoweri opened this issue Apr 28, 2020 · 3 comments · Fixed by #1221
Closed

New Docs Site: Can't Close Nav By Tapping Outside on Mobile #1169

sghoweri opened this issue Apr 28, 2020 · 3 comments · Fixed by #1221
Labels
released 🚀 website

Comments

@sghoweri
Copy link
Contributor

sghoweri commented Apr 28, 2020 •
edited
Loading

Expected Behavior

Tapping anywhere outside of the main Nav while expanded will automatically close the main Nav (aka like how Dropdowns normally work)

Actual Behavior

Nav remains open when tapping / interacting with any UI outside of it.

6F05C89D-AE40-4A3A-A71F-6E0352294331
mfranzke pushed a commit to mfranzke/patternlab-node that referenced this issue Jun 13, 2020
improvement(nav): closing nav on tapping outside on mobile pattern-la…
9ccf47f 
…b#1169
@mfranzke mfranzke mentioned this issue Jun 13, 2020
Merged
@stale
Copy link

stale bot commented Jun 28, 2020

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@mfranzke
Copy link
Contributor

Fight the bot

sghoweri added a commit that referenced this issue Jun 28, 2020
@sghoweri
Merge pull request #1221 from mfranzke/improvement-nav-closing-nav-on…
e780e21 
…-tapping-outside-on-mobile

improvement(nav): closing nav on tapping outside on mobile #1169
@sghoweri
Copy link
Contributor Author

Issue was released with v5.11.1

antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this issue Apr 12, 2023
@sghoweri
Merge pull request pattern-lab#1221 from mfranzke/improvement-nav-clo…
549ea59 
…sing-nav-on-tapping-outside-on-mobile

improvement(nav): closing nav on tapping outside on mobile pattern-lab#1169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released 🚀 website
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improvement(nav): closing nav on tapping outside on mobile #1169 mfranzke/patternlab-node
2 participants
@mfranzke @sghoweri