You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a Pattern Lab implementation I'm porting over from PHP. The PHP version allows the following syntax for partials:
{{> templates-article }}
{{> 03-templates/02-article }}
{{> 03-templates/02-article.mustache }}
The Node version only allows the first. The greater flexibility of the PHP version is mandatory for my implementation. I'm submitting a pull request to allow for this. Please review, comment, and merge. Thanks!
The text was updated successfully, but these errors were encountered:
This would be a welcome addition @e2tha-e I was not aware the PHP version supported those. In my opinion they are not necessary because the "pattern key" in all instances is templates-article and the numerals are just a poorman's ordering device - but by all means PR away!
Please do add some unit tests wherever partials are being tested too.
@bmuenzenmeyer I found the only advantage to the terse partials was terseness. As the project got bigger, knowing the exact paths of partials was a HUGE timesaver. And on top of that, I created a Mustache file browser which allowed you to recurse through many levels of partials, and this also required exact paths.
I have a Pattern Lab implementation I'm porting over from PHP. The PHP version allows the following syntax for partials:
The Node version only allows the first. The greater flexibility of the PHP version is mandatory for my implementation. I'm submitting a pull request to allow for this. Please review, comment, and merge. Thanks!
The text was updated successfully, but these errors were encountered: