Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BrowserSync still happens on the outer frame after full refresh on pattern #273

Closed
geoffp opened this issue Feb 27, 2016 · 3 comments
Closed

Comments

@geoffp
Copy link
Contributor

geoffp commented Feb 27, 2016

I am using Pattern Lab Node v1.1.3 on Mac|Linux, using the grunt|gulp configuration.

Expected Behavior

You should be able to go to a pattern, or other non-/ URL, such as those documented in http://patternlab.io/docs/pattern-linking.html, and BrowserSync should not inject itself into the UI chrome, or "outer frame".

Actual Behavior

It totally still does in that case.

Steps to Reproduce
  1. Select a pattern from the menu.
  2. Refresh the entire page.
  3. Witness two overlapping BS badges on the lower right. 😢
@geoffp geoffp changed the title BrowserSync still happens on the outer frame after fullr refresh on pattern BrowserSync still happens on the outer frame after full refresh on pattern Feb 27, 2016
@geoffp
Copy link
Contributor Author

geoffp commented Feb 27, 2016

cc @vlrprbttst

@vlrprbttst
Copy link

+1!

@bmuenzenmeyer
Copy link
Member

This is in dev.

Internal Note:
There is not a "Closes #273" statement in any commit so it will likely not auto close when it reaches master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants