Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underscored Patterns are being built on the UI #300

Closed
bmuenzenmeyer opened this issue Apr 3, 2016 · 1 comment
Closed

Underscored Patterns are being built on the UI #300

bmuenzenmeyer opened this issue Apr 3, 2016 · 1 comment
Labels
bug 🐛 staged for next release 🏁

Comments

@bmuenzenmeyer
Copy link
Member

On the dev-2.0-core branch.

If styleguideexcludes is empty in the config, no check ever occurs to exclude _underscored patterns.
This logic needs to be more sophisticated.

This logic should be checked in 1.X
bmuenzenmeyer added a commit that referenced this issue Apr 4, 2016
@bmuenzenmeyer
Underscored Patterns are being built on the UI if styleguide excludes…
da403fd 
… was missing or empty

closes #300
@bmuenzenmeyer
Copy link
Member Author

Need to pull this into dev-2.0-core as well.

This was referenced Apr 5, 2016
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 staged for next release 🏁
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bmuenzenmeyer