Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pattern.patternSubGroup no longer parsing correctly #347

Closed
bmuenzenmeyer opened this issue Jun 3, 2016 · 0 comments
Closed

Pattern.patternSubGroup no longer parsing correctly #347

bmuenzenmeyer opened this issue Jun 3, 2016 · 0 comments
Labels
bug 🐛 staged for next release 🏁
Milestone
2.0-alpha

Comments

@bmuenzenmeyer
Copy link
Member

bmuenzenmeyer commented Jun 3, 2016 •
edited
Loading

I am using Pattern Lab Node v2.0.0 on Windows, using the gulp edition.

Found while attempting to implement pattern-lab/edition-node-gulp#27

object_factory patternSubGroup no longer appears to report what it's comment is

For atoms-colors pattern, it should output global, but it appears to output as Atoms\01 Global
both in the nav

image

and in the pattern breadcrumb

image
@bmuenzenmeyer bmuenzenmeyer added this to the 2.0-alpha milestone Jun 3, 2016
bmuenzenmeyer added a commit that referenced this issue Jun 3, 2016
@bmuenzenmeyer
pushed to support pattern-lab/edition-node-gulp#27 once #347 is fixed
dc6cd22
@geoffp geoffp mentioned this issue Jun 3, 2016
Merged
bmuenzenmeyer pushed a commit that referenced this issue Jun 3, 2016
Merge pull request #348 from pattern-lab/fix-347
20787f0 
Hopefully fix #347. Use Path tools and regex instead of hackish
bmuenzenmeyer added a commit that referenced this issue Jun 3, 2016
@bmuenzenmeyer
better handles flat patterns when constructing the breadcrumb
618f8fd 
fixes #347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 staged for next release 🏁
Projects
None yet
Milestone
2.0-alpha
Development

No branches or pull requests
2 participants
@geoffp @bmuenzenmeyer