Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for Underscore, Handlebars, and Twig fail #438

Closed
geoffp opened this issue Aug 17, 2016 · 2 comments
Closed

Tests for Underscore, Handlebars, and Twig fail #438

geoffp opened this issue Aug 17, 2016 · 2 comments
Labels
staged for next release 🏁

Comments

@geoffp
Copy link
Contributor

geoffp commented Aug 17, 2016 •
edited
Loading

I am using Pattern Lab Node v2.4.2 on Mac, with Node v4.4.7, using the Gulp Edition.

Expected Behavior

Unit tests for all engines should run.

Actual Behavior

Tests for Underscore, Handlebars, and Twig fail due to missing outputFileSuffix blob in the included patternlab-config.json.

I'll do a PR to get the config that we provide by default in the gulp edition into this, as well as make that the default.
@geoffp geoffp self-assigned this Aug 17, 2016
bmuenzenmeyer added a commit that referenced this issue Aug 18, 2016
@bmuenzenmeyer
experimenting with travis install of all engines
80c9c97 
part of #438
@bmuenzenmeyer bmuenzenmeyer self-assigned this Aug 18, 2016
@bmuenzenmeyer
Copy link
Member

Travis can now load engines during test (at least what has been npm published)

https://travis-ci.org/pattern-lab/patternlab-node/builds/153287099

@geoffp
Copy link
Contributor Author

geoffp commented Aug 18, 2016

Excellent!

@bmuenzenmeyer bmuenzenmeyer mentioned this issue Aug 19, 2016
Merged
@geoffp geoffp mentioned this issue Aug 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
staged for next release 🏁
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@geoffp @bmuenzenmeyer