Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite tests to use a node friendly test suite #466

Closed
raphaelokon opened this issue Sep 2, 2016 · 4 comments
Closed

Rewrite tests to use a node friendly test suite #466

raphaelokon opened this issue Sep 2, 2016 · 4 comments

Comments

@raphaelokon
Copy link
Contributor

The current implementation utilizes grunt-contrib-nodeunit.
I suggest to use a more node-friendly test suite like tap. There are many benefits to use a simple and concise test suite:

@bmuenzenmeyer
Copy link
Member

As we discussed, the unit tests are in need of a level up. I love this idea.

@raphaelokon
Copy link
Contributor Author

Cheers … I already utilizing tap (node-tap) for the CLI test. Also: the current tests npm test run (or try to run) Travis locally. This should probably be changed for better dev experience.

@dbradf
Copy link

dbradf commented Oct 2, 2016

Hi,

I've added tap support to the project and converted over the of the test files to get started with this issue. I've opened the above pull request.

@raphaelokon
Copy link
Contributor Author

That's great @dbradf I use tap on the patternlab-node-cli as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants