Rename annotations.js to annotations.json

[henk23]

It's a json file, so why does it have a js file ending?
My IDE complains about corrupted js syntax and I think it is right about it.
What am I not seeing here?

[bmuenzenmeyer]

@henk23 it's a good question!

what you aren't seeing is the support for the legacy Pattern Lab annotations file - which was a js file WITH js in it, instead of simpler JSON/YML. Seems it's undergone half the needed changes, but was perhaps never finished due to concern for cross-platform support. Since core is in 3.0 alpha anyways, it'd be smart to fix this once and for all, which will make the code simpler too!

• rename https://github.com/pattern-lab/starterkit-mustache-demo/blob/master/dist/_annotations/annotations.js BREAKING CHANGE to starterkit needed
• reconcile / remove old format code :

  patternlab-node/packages/core/src/lib/annotation_exporter.js

  Lines 33 to 48 in 66bf964

  	//parse as JSON by removing the old wrapping js syntax. comments and the trailing semi-colon
  	oldAnnotations = oldAnnotations.replace('var comments = ', '');
  	oldAnnotations = oldAnnotations.replace('};', '}');
  	try {
  	const oldAnnotationsJSON = JSON.parse(oldAnnotations);
  	return oldAnnotationsJSON.comments;
  	} catch (ex) {
  	logger.error(
  	`There was an error parsing JSON for ${
  	paths.source.annotations
  	}annotations.js`
  	);
  	return [];
  	}
  	}

[bmuenzenmeyer]

fixed