Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement exclude tags feature. #1140

Merged
merged 12 commits into from
May 9, 2020

Conversation

Hydraner
Copy link
Contributor

Closes #844
Closes #1079

Summary of changes:

  • Extends uikitExcludePattern to also check for tags
  • Tests for excludeTags config

@sghoweri sghoweri self-assigned this Mar 17, 2020
@bmuenzenmeyer
Copy link
Member

Excited to see a feature long-promised add to the project!

packages/core/src/lib/uikitExcludePattern.js Outdated Show resolved Hide resolved
packages/core/src/lib/uikitExcludePattern.js Outdated Show resolved Hide resolved
packages/core/src/lib/uikitExcludePattern.js Outdated Show resolved Hide resolved
bmuenzenmeyer and others added 6 commits May 1, 2020 07:13
Co-authored-by: Josef Bredreck <slime.games@outlook.de>
Co-authored-by: Josef Bredreck <slime.games@outlook.de>
Co-authored-by: Josef Bredreck <slime.games@outlook.de>
Co-authored-by: Josef Bredreck <slime.games@outlook.de>
@sghoweri
Copy link
Contributor

sghoweri commented May 9, 2020

@JosefBredereck @Hydraner are we good to go on this?

@JosefBredereck
Copy link
Contributor

As @bmuenzenmeyer accepted the review corrections it is ready.

@sghoweri sghoweri merged commit a6b0c84 into pattern-lab:dev May 9, 2020
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement config option "excludedPatternTags" UIKit excluded tag support
4 participants