Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(config-theme): enhanced related to current implementation #1214

Merged

Conversation

mfranzke
Copy link
Contributor

@mfranzke mfranzke commented Jun 3, 2020

The theme documentation is missing two configuration options.

Summary of changes:
Added missing options noViewAll (config.theme.noViewAll) and logo (config.theme.logo).

added both config.theme.noViewAll and config.theme.logo
@sghoweri sghoweri self-requested a review June 28, 2020 16:56
Copy link
Contributor

@sghoweri sghoweri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS @mfranzke! 🙏

PS. Sorry these docs weren't included in my original PR for this. 😅

@sghoweri sghoweri merged commit 53eef5f into pattern-lab:dev Jun 28, 2020
@mfranzke mfranzke deleted the improvement-docs-config-theme-options branch June 28, 2020 17:56
@sghoweri
Copy link
Contributor

PR was released with v5.11.1

antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
…nfig-theme-options

docs(config-theme): enhanced related to current implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants