-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unhandled promise rejection on server.open #1234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Any reason npm create still uses 5.12.0 ? NPMJS doesn't carry create-pattern-lab 5.13.0 yet. Also, when manually installing @pattern-lab/cli 5.13.0 in an empty directory (macOS Mojave):
It then remains (indefinitely ?) on that last line, with the node process no longer eating any CPU, so apparently stuck. |
Oh, yes. I had no access rights to the npm package but I should now have. I will change that today. Very good hint. |
Also, your error message looks more like #916, where an error occurs during installation. |
Fix unhandled promise rejection on server.open
Closes #1231
Summary of changes:
In a docker container with no browser installed, an unhandled promise rejection occured when
pl:serve
tried to open pattern lab in a browser.