Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix live-server injects code to SVGs #1235

Merged
merged 4 commits into from
Aug 26, 2020
Merged

Fix live-server injects code to SVGs #1235

merged 4 commits into from
Aug 26, 2020

Conversation

JosefBredereck
Copy link
Contributor

Closes #1019

Summary of changes:

Since we never render a page without head or body it makes no sence to inject code to SVGs and it also could lead to some unexpected behavior.

@JosefBredereck JosefBredereck changed the title #1019: Fix live-server injects code to SVGs Fix live-server injects code to SVGs Aug 16, 2020
@coveralls
Copy link

coveralls commented Aug 25, 2020

Coverage Status

Coverage remained the same at 74.386% when pulling 2a01972 on fix-1019 into 9c4c821 on dev.

@sghoweri sghoweri self-requested a review August 26, 2020 00:13
Copy link
Contributor

@sghoweri sghoweri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super familiar with the live-server still shipping in Pattern Lab (mainly given awesome off the shelf options like Webpack Dev Server or Browsersync) but this regex update makes sense so I'm good with this 👍

@sghoweri sghoweri merged commit 719932f into dev Aug 26, 2020
@sghoweri sghoweri deleted the fix-1019 branch August 26, 2020 00:46
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
Fix live-server injects code to SVGs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

live-server injects code in HTML source view inside SVG tags
3 participants